Title: [188688] trunk/Source/_javascript_Core
- Revision
- 188688
- Author
- [email protected]
- Date
- 2015-08-20 10:40:48 -0700 (Thu, 20 Aug 2015)
Log Message
Fixed some warnings on Windows.
https://bugs.webkit.org/show_bug.cgi?id=148224
Reviewed by Brent Fulgham.
The Windows build was complaining that function params were hiding a global variable.
Since the function params were unused, I resolved this by removing the param names.
* API/tests/ExecutionTimeLimitTest.cpp:
(currentCPUTimeAsJSFunctionCallback):
(shouldTerminateCallback):
(cancelTerminateCallback):
(extendTerminateCallback):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp (188687 => 188688)
--- trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp 2015-08-20 16:43:53 UTC (rev 188687)
+++ trunk/Source/_javascript_Core/API/tests/ExecutionTimeLimitTest.cpp 2015-08-20 17:40:48 UTC (rev 188688)
@@ -52,27 +52,22 @@
}
bool shouldTerminateCallbackWasCalled = false;
-static bool shouldTerminateCallback(JSContextRef ctx, void* context)
+static bool shouldTerminateCallback(JSContextRef, void*)
{
- UNUSED_PARAM(ctx);
- UNUSED_PARAM(context);
shouldTerminateCallbackWasCalled = true;
return true;
}
bool cancelTerminateCallbackWasCalled = false;
-static bool cancelTerminateCallback(JSContextRef ctx, void* context)
+static bool cancelTerminateCallback(JSContextRef, void*)
{
- UNUSED_PARAM(ctx);
- UNUSED_PARAM(context);
cancelTerminateCallbackWasCalled = true;
return false;
}
int extendTerminateCallbackCalled = 0;
-static bool extendTerminateCallback(JSContextRef ctx, void* context)
+static bool extendTerminateCallback(JSContextRef ctx, void*)
{
- UNUSED_PARAM(context);
extendTerminateCallbackCalled++;
if (extendTerminateCallbackCalled == 1) {
JSContextGroupRef contextGroup = JSContextGetGroup(ctx);
Modified: trunk/Source/_javascript_Core/ChangeLog (188687 => 188688)
--- trunk/Source/_javascript_Core/ChangeLog 2015-08-20 16:43:53 UTC (rev 188687)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-08-20 17:40:48 UTC (rev 188688)
@@ -1,3 +1,19 @@
+2015-08-20 Mark Lam <[email protected]>
+
+ Fixed some warnings on Windows.
+ https://bugs.webkit.org/show_bug.cgi?id=148224
+
+ Reviewed by Brent Fulgham.
+
+ The Windows build was complaining that function params were hiding a global variable.
+ Since the function params were unused, I resolved this by removing the param names.
+
+ * API/tests/ExecutionTimeLimitTest.cpp:
+ (currentCPUTimeAsJSFunctionCallback):
+ (shouldTerminateCallback):
+ (cancelTerminateCallback):
+ (extendTerminateCallback):
+
2015-08-19 Yusuke Suzuki <[email protected]>
Add InternalPromise to use Promises safely in the internals
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
