Title: [188691] trunk/Source/WebInspectorUI
- Revision
- 188691
- Author
- [email protected]
- Date
- 2015-08-20 11:11:46 -0700 (Thu, 20 Aug 2015)
Log Message
Web Inspector: console assertion when hitting breakpoint after auto-recording ends
https://bugs.webkit.org/show_bug.cgi?id=148225
Reviewed by Timothy Hatcher.
Add checks for the precondition to starting/stopping time updates.
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
(WebInspector.TimelineRecordingContentView.prototype._debuggerPaused):
(WebInspector.TimelineRecordingContentView.prototype._debuggerResumed):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188690 => 188691)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-20 17:47:08 UTC (rev 188690)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-20 18:11:46 UTC (rev 188691)
@@ -1,3 +1,17 @@
+2015-08-20 Brian Burg <[email protected]>
+
+ Web Inspector: console assertion when hitting breakpoint after auto-recording ends
+ https://bugs.webkit.org/show_bug.cgi?id=148225
+
+ Reviewed by Timothy Hatcher.
+
+ Add checks for the precondition to starting/stopping time updates.
+
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
+ (WebInspector.TimelineRecordingContentView.prototype._debuggerPaused):
+ (WebInspector.TimelineRecordingContentView.prototype._debuggerResumed):
+
2015-08-19 Brian Burg <[email protected]>
Web Inspector: add TestHarness option to tee all commands to system console
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (188690 => 188691)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2015-08-20 17:47:08 UTC (rev 188690)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2015-08-20 18:11:46 UTC (rev 188691)
@@ -488,7 +488,8 @@
_capturingStarted(event)
{
- this._startUpdatingCurrentTime(event.data.startTime);
+ if (!this._updating)
+ this._startUpdatingCurrentTime(event.data.startTime);
}
_capturingStopped(event)
@@ -502,7 +503,8 @@
if (WebInspector.replayManager.sessionState === WebInspector.ReplayManager.SessionState.Replaying)
return;
- this._stopUpdatingCurrentTime();
+ if (this._updating)
+ this._stopUpdatingCurrentTime();
}
_debuggerResumed(event)
@@ -510,7 +512,8 @@
if (WebInspector.replayManager.sessionState === WebInspector.ReplayManager.SessionState.Replaying)
return;
- this._startUpdatingCurrentTime();
+ if (!this._updating)
+ this._startUpdatingCurrentTime();
}
_recordingTimesUpdated(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
