Title: [188698] trunk/LayoutTests
Revision
188698
Author
[email protected]
Date
2015-08-20 13:53:26 -0700 (Thu, 20 Aug 2015)

Log Message

REGRESSION: http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html is very flaky
https://bugs.webkit.org/show_bug.cgi?id=148205

Unreviewed, give the disk cache a chance to settle down before querying
the resource again. This fixes the flakiness locally. Longer term, I will
try and figure out why the cache is sometimes revalidating if the resource
is requested very quickly after.

* http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (188697 => 188698)


--- trunk/LayoutTests/ChangeLog	2015-08-20 20:46:04 UTC (rev 188697)
+++ trunk/LayoutTests/ChangeLog	2015-08-20 20:53:26 UTC (rev 188698)
@@ -1,3 +1,15 @@
+2015-08-20  Chris Dumez  <[email protected]>
+
+        REGRESSION: http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html is very flaky
+        https://bugs.webkit.org/show_bug.cgi?id=148205
+
+        Unreviewed, give the disk cache a chance to settle down before querying
+        the resource again. This fixes the flakiness locally. Longer term, I will
+        try and figure out why the cache is sometimes revalidating if the resource
+        is requested very quickly after.
+
+        * http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html:
+
 2015-08-11  Yusuke Suzuki  <[email protected]>
 
         Introduce put_by_id like IC into put_by_val when the given name is String or Symbol

Modified: trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html (188697 => 188698)


--- trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html	2015-08-20 20:46:04 UTC (rev 188697)
+++ trunk/LayoutTests/http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html	2015-08-20 20:53:26 UTC (rev 188698)
@@ -13,8 +13,11 @@
 debug("");
 
 runTests(tests, function() {
-    debug("304 response included an 'Expires' header in the future, so we should not need to revalidate this time.");
-    runTests(tests);
+    // Wait for things to settle down in the cache.
+    setTimeout(function() {
+        debug("304 response included an 'Expires' header in the future, so we should not need to revalidate this time.");
+        runTests(tests);
+    }, 200);
 });
 
 </script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to