Title: [188706] branches/jsc-tailcall/Source/_javascript_Core
Revision
188706
Author
[email protected]
Date
2015-08-20 14:55:10 -0700 (Thu, 20 Aug 2015)

Log Message

jsc-tailcall: Stack pointer should be moved to protect saving callee saves in LLInt
https://bugs.webkit.org/show_bug.cgi?id=148246

Reviewed by Basile Clement.

Changed preserveCalleeSavesUsedByLLInt() macro to move the stack pointer before saving
any registers.

* llint/LowLevelInterpreter.asm:

Modified Paths

Diff

Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (188705 => 188706)


--- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog	2015-08-20 21:54:03 UTC (rev 188705)
+++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog	2015-08-20 21:55:10 UTC (rev 188706)
@@ -1,3 +1,15 @@
+2015-08-20  Michael Saboff  <[email protected]>
+
+        jsc-tailcall: Stack pointer should be moved to protect saving callee saves in LLInt
+        https://bugs.webkit.org/show_bug.cgi?id=148246
+
+        Reviewed by Basile Clement.
+
+        Changed preserveCalleeSavesUsedByLLInt() macro to move the stack pointer before saving
+        any registers.
+
+        * llint/LowLevelInterpreter.asm:
+
 2015-08-19  Michael Saboff  <[email protected]>
 
         jsc-tailcall: Unify Register Offset classes

Modified: branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm (188705 => 188706)


--- branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm	2015-08-20 21:54:03 UTC (rev 188705)
+++ branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm	2015-08-20 21:55:10 UTC (rev 188706)
@@ -504,6 +504,7 @@
 end
 
 macro preserveCalleeSavesUsedByLLInt()
+    subp CalleeSaveSpaceStackAligned, sp
     if C_LOOP
     elsif ARM or ARMv7_TRADITIONAL
     elsif ARMv7
@@ -875,7 +876,7 @@
 
     # Stack height check failed - need to call a slow_path.
     # Set up temporary stack pointer for call including callee saves
-    subp maxFrameExtentForSlowPathCall + CalleeSaveSpaceStackAligned, sp
+    subp maxFrameExtentForSlowPathCall, sp
     callSlowPath(_llint_stack_check)
     bpeq r1, 0, .stackHeightOKGetCodeBlock
     move r1, cfr
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to