Title: [188731] trunk/Source/WebInspectorUI
- Revision
- 188731
- Author
- drou...@apple.com
- Date
- 2015-08-20 18:38:56 -0700 (Thu, 20 Aug 2015)
Log Message
Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links
https://bugs.webkit.org/show_bug.cgi?id=148264
Reviewed by Timothy Hatcher.
* UserInterface/Views/VisualStylePropertyEditorLink.js:
(WebInspector.VisualStylePropertyEditorLink.prototype.set linked):
No longer attempts to set the "hidden" attribute of the link icons before they exist.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188730 => 188731)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-21 01:37:40 UTC (rev 188730)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-21 01:38:56 UTC (rev 188731)
@@ -1,5 +1,16 @@
2015-08-20 Devin Rousso <drou...@apple.com>
+ Web Inspector: Fix "attempted to assign to readonly property" in Visual editor links
+ https://bugs.webkit.org/show_bug.cgi?id=148264
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/VisualStylePropertyEditorLink.js:
+ (WebInspector.VisualStylePropertyEditorLink.prototype.set linked):
+ No longer attempts to set the "hidden" attribute of the link icons before they exist.
+
+2015-08-20 Devin Rousso <drou...@apple.com>
+
Web Inspector: Visual editor adds extra spaces to styles with no properties
https://bugs.webkit.org/show_bug.cgi?id=148242
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.js (188730 => 188731)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.js 2015-08-21 01:37:40 UTC (rev 188730)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStylePropertyEditorLink.js 2015-08-21 01:38:56 UTC (rev 188731)
@@ -82,8 +82,13 @@
{
this._linked = flag;
this._element.classList.toggle("linked", this._linked);
- this._linkedIcon.hidden = !this._linked;
- this._unlinkedIcon.hidden = this._linked;
+
+ if (this._linkedIcon)
+ this._linkedIcon.hidden = !this._linked;
+
+ if (this._unlinkedIcon)
+ this._unlinkedIcon.hidden = this._linked;
+
this._iconElement.title = this._linked ? WebInspector.UIString("Click to remove link") : WebInspector.UIString("Click to link property values");
for (let linkToHide of this._linksToHideWhenLinked)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
