Title: [188746] trunk/LayoutTests
- Revision
- 188746
- Author
- [email protected]
- Date
- 2015-08-20 20:12:25 -0700 (Thu, 20 Aug 2015)
Log Message
AX: fix accessibility/loading-iframe-updates-axtree.html test for mac
https://bugs.webkit.org/show_bug.cgi?id=148251
Patch by Nan Wang <[email protected]> on 2015-08-20
Reviewed by Chris Fleizach.
Added a container in order to make the frame accessible. Also, added expected results for
both WK1 and WK2.
* accessibility/loading-iframe-updates-axtree-expected.txt:
* accessibility/loading-iframe-updates-axtree.html:
* platform/mac-wk1/accessibility: Added.
* platform/mac-wk1/accessibility/loading-iframe-updates-axtree-expected.txt: Added.
* platform/mac/TestExpectations:
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (188745 => 188746)
--- trunk/LayoutTests/ChangeLog 2015-08-21 03:05:02 UTC (rev 188745)
+++ trunk/LayoutTests/ChangeLog 2015-08-21 03:12:25 UTC (rev 188746)
@@ -1,3 +1,19 @@
+2015-08-20 Nan Wang <[email protected]>
+
+ AX: fix accessibility/loading-iframe-updates-axtree.html test for mac
+ https://bugs.webkit.org/show_bug.cgi?id=148251
+
+ Reviewed by Chris Fleizach.
+
+ Added a container in order to make the frame accessible. Also, added expected results for
+ both WK1 and WK2.
+
+ * accessibility/loading-iframe-updates-axtree-expected.txt:
+ * accessibility/loading-iframe-updates-axtree.html:
+ * platform/mac-wk1/accessibility: Added.
+ * platform/mac-wk1/accessibility/loading-iframe-updates-axtree-expected.txt: Added.
+ * platform/mac/TestExpectations:
+
2015-08-20 Chris Dumez <[email protected]>
Fix passing null / undefined as NodeFilter parameter for createNodeIterator() / createTreeWalker()
Modified: trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt (188745 => 188746)
--- trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt 2015-08-21 03:05:02 UTC (rev 188745)
+++ trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt 2015-08-21 03:12:25 UTC (rev 188746)
@@ -10,9 +10,9 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS iframe.isEqual(newIframe) is true
-PASS scrollarea.isEqual(newScrollarea) is false
-PASS subwebarea.isEqual(newSubwebarea) is false
+iframe.isEqual(newIframe): true
+scrollarea.isEqual(newScrollarea): false
+subwebarea.isEqual(newSubwebarea): false
PASS newSubwebarea.childrenCount > 0 is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html (188745 => 188746)
--- trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html 2015-08-21 03:05:02 UTC (rev 188745)
+++ trunk/LayoutTests/accessibility/loading-iframe-updates-axtree.html 2015-08-21 03:12:25 UTC (rev 188746)
@@ -11,7 +11,7 @@
description("This tests that if an iframe loads new content after its accessibility object has already been accessed, the iframe accessibility object's descendants are the new scroll area and web area, not the old deleted ones.");
if (window.accessibilityController) {
- window.iframe = accessibilityController.accessibleElementById('iframe');
+ window.iframe = accessibilityController.accessibleElementById('iframeContainer');
window.scrollarea = iframe.childAtIndex(0);
window.subwebarea = scrollarea.childAtIndex(0);
}
@@ -19,13 +19,17 @@
window.iframeElement = document.getElementById("iframe");
iframeElement.addEventListener("load", function() {
if (window.accessibilityController) {
- window.newIframe = accessibilityController.accessibleElementById('iframe');
+ window.newIframe = accessibilityController.accessibleElementById('iframeContainer');
window.newScrollarea = newIframe.childAtIndex(0);
window.newSubwebarea = newScrollarea.childAtIndex(0);
- shouldBeTrue("iframe.isEqual(newIframe)");
- shouldBeFalse("scrollarea.isEqual(newScrollarea)");
- shouldBeFalse("subwebarea.isEqual(newSubwebarea)");
+ // for WK1, the scroll area does not change
+ var iframeEqual = iframe.isEqual(newIframe);
+ var scrollareaEqual = scrollarea.isEqual(newScrollarea);
+ var subwebareaEqual = subwebarea.isEqual(newSubwebarea);
+ debug("iframe.isEqual(newIframe): " + iframeEqual);
+ debug("scrollarea.isEqual(newScrollarea): " + scrollareaEqual);
+ debug("subwebarea.isEqual(newSubwebarea): " + subwebareaEqual);
shouldBeTrue("newSubwebarea.childrenCount > 0");
}
@@ -51,7 +55,9 @@
<p>Before</p>
-<iframe id="iframe" role="group"></iframe>
+<div id="iframeContainer">
+<iframe id="iframe"></iframe>
+</div>
<p>After</p>
Modified: trunk/LayoutTests/platform/mac/TestExpectations (188745 => 188746)
--- trunk/LayoutTests/platform/mac/TestExpectations 2015-08-21 03:05:02 UTC (rev 188745)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-08-21 03:12:25 UTC (rev 188746)
@@ -35,9 +35,6 @@
fast/dom/Window/slow-unload-handler.html
fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html
-# This test fails on release and crashes on debug because of trying to use isEqual() with undefined objects
-webkit.org/b/126066 accessibility/loading-iframe-updates-axtree.html [ Failure Crash ]
-
webkit.org/b/116636 accessibility/document-attributes.html [ Failure ]
# Accessibility tests with missing AccessibilityController functionality.
Copied: trunk/LayoutTests/platform/mac-wk1/accessibility/loading-iframe-updates-axtree-expected.txt (from rev 188745, trunk/LayoutTests/accessibility/loading-iframe-updates-axtree-expected.txt) (0 => 188746)
--- trunk/LayoutTests/platform/mac-wk1/accessibility/loading-iframe-updates-axtree-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac-wk1/accessibility/loading-iframe-updates-axtree-expected.txt 2015-08-21 03:12:25 UTC (rev 188746)
@@ -0,0 +1,19 @@
+Before
+
+
+After
+
+End of test
+
+This tests that if an iframe loads new content after its accessibility object has already been accessed, the iframe accessibility object's descendants are the new scroll area and web area, not the old deleted ones.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+iframe.isEqual(newIframe): true
+scrollarea.isEqual(newScrollarea): true
+subwebarea.isEqual(newSubwebarea): false
+PASS newSubwebarea.childrenCount > 0 is true
+
+TEST COMPLETE
+
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
