Title: [188760] trunk/Source/WebInspectorUI
- Revision
- 188760
- Author
- [email protected]
- Date
- 2015-08-21 11:27:01 -0700 (Fri, 21 Aug 2015)
Log Message
Web Inspector: clean up uses of `new` with zero-argument constructors and factory methods
https://bugs.webkit.org/show_bug.cgi?id=148311
Reviewed by Timothy Hatcher.
* UserInterface/Protocol/InspectorFrontendHostStub.js:
* UserInterface/Views/ClusterContentView.js:
(WebInspector.ClusterContentView):
* UserInterface/Views/ColorPicker.js:
(WebInspector.ColorPicker):
* UserInterface/Views/ContentView.js:
(WebInspector.ContentView.createFromRepresentedObject): This was causing a console assertion
when a breakpoint tree element was selected and the inspector tried to restore the view state
after a reload or back/forward navigation.
* UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel):
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188759 => 188760)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-21 18:26:23 UTC (rev 188759)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-21 18:27:01 UTC (rev 188760)
@@ -1,3 +1,25 @@
+2015-08-21 Brian Burg <[email protected]>
+
+ Web Inspector: clean up uses of `new` with zero-argument constructors and factory methods
+ https://bugs.webkit.org/show_bug.cgi?id=148311
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Protocol/InspectorFrontendHostStub.js:
+ * UserInterface/Views/ClusterContentView.js:
+ (WebInspector.ClusterContentView):
+ * UserInterface/Views/ColorPicker.js:
+ (WebInspector.ColorPicker):
+ * UserInterface/Views/ContentView.js:
+ (WebInspector.ContentView.createFromRepresentedObject): This was causing a console assertion
+ when a breakpoint tree element was selected and the inspector tried to restore the view state
+ after a reload or back/forward navigation.
+
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WebInspector.NavigationSidebarPanel):
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WebInspector.TimelineRecordingContentView):
+
2015-08-20 Brian Burg <[email protected]>
Web Inspector: add a regression test for the fix introduced in r188679
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js (188759 => 188760)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js 2015-08-21 18:26:23 UTC (rev 188759)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendHostStub.js 2015-08-21 18:27:01 UTC (rev 188760)
@@ -172,7 +172,7 @@
}
};
- InspectorFrontendHost = new WebInspector.InspectorFrontendHostStub();
+ InspectorFrontendHost = new WebInspector.InspectorFrontendHostStub;
WebInspector.dontLocalizeUserInterface = true;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js (188759 => 188760)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js 2015-08-21 18:26:23 UTC (rev 188759)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js 2015-08-21 18:27:01 UTC (rev 188760)
@@ -31,7 +31,7 @@
this.element.classList.add("cluster");
- this._contentViewContainer = new WebInspector.ContentViewContainer();
+ this._contentViewContainer = new WebInspector.ContentViewContainer;
this._contentViewContainer.addEventListener(WebInspector.ContentViewContainer.Event.CurrentContentViewDidChange, this._currentContentViewDidChange, this);
this.element.appendChild(this._contentViewContainer.element);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js (188759 => 188760)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js 2015-08-21 18:26:23 UTC (rev 188759)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ColorPicker.js 2015-08-21 18:27:01 UTC (rev 188760)
@@ -29,15 +29,15 @@
{
super();
- this._colorWheel = new WebInspector.ColorWheel();
+ this._colorWheel = new WebInspector.ColorWheel;
this._colorWheel.delegate = this;
this._colorWheel.dimension = 200;
- this._brightnessSlider = new WebInspector.Slider();
+ this._brightnessSlider = new WebInspector.Slider;
this._brightnessSlider.delegate = this;
this._brightnessSlider.element.classList.add("brightness");
- this._opacitySlider = new WebInspector.Slider();
+ this._opacitySlider = new WebInspector.Slider;
this._opacitySlider.delegate = this;
this._opacitySlider.element.classList.add("opacity");
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js (188759 => 188760)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2015-08-21 18:26:23 UTC (rev 188759)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2015-08-21 18:27:01 UTC (rev 188760)
@@ -75,7 +75,7 @@
if (representedObject instanceof WebInspector.Breakpoint) {
if (representedObject.sourceCodeLocation)
- return new WebInspector.ContentView.createFromRepresentedObject(representedObject.sourceCodeLocation.displaySourceCode, extraArguments);
+ return WebInspector.ContentView.createFromRepresentedObject(representedObject.sourceCodeLocation.displaySourceCode, extraArguments);
}
if (representedObject instanceof WebInspector.DOMStorageObject)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (188759 => 188760)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2015-08-21 18:26:23 UTC (rev 188759)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2015-08-21 18:27:01 UTC (rev 188760)
@@ -37,7 +37,7 @@
this._contentTreeOutline = this.createContentTreeOutline(true);
- this._filterBar = new WebInspector.FilterBar();
+ this._filterBar = new WebInspector.FilterBar;
this._filterBar.addEventListener(WebInspector.FilterBar.Event.FilterDidChange, this._filterDidChange, this);
this.element.appendChild(this._filterBar.element);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (188759 => 188760)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2015-08-21 18:26:23 UTC (rev 188759)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2015-08-21 18:27:01 UTC (rev 188760)
@@ -48,7 +48,7 @@
this._currentTimelineOverview = this._linearTimelineOverview;
this.element.appendChild(this._currentTimelineOverview.element);
- this._contentViewContainer = new WebInspector.ContentViewContainer();
+ this._contentViewContainer = new WebInspector.ContentViewContainer;
this._contentViewContainer.addEventListener(WebInspector.ContentViewContainer.Event.CurrentContentViewDidChange, this._currentContentViewDidChange, this);
this.element.appendChild(this._contentViewContainer.element);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
