Title: [188798] trunk/Source/WTF
- Revision
- 188798
- Author
- [email protected]
- Date
- 2015-08-21 16:37:24 -0700 (Fri, 21 Aug 2015)
Log Message
Address review feedback from Darin.
* wtf/MainThread.h:
* wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
(WTF::callOnMainThread):
(WTF::cancelCallOnMainThread):
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (188797 => 188798)
--- trunk/Source/WTF/ChangeLog 2015-08-21 23:34:07 UTC (rev 188797)
+++ trunk/Source/WTF/ChangeLog 2015-08-21 23:37:24 UTC (rev 188798)
@@ -1,5 +1,14 @@
2015-08-21 Anders Carlsson <[email protected]>
+ Address review feedback from Darin.
+
+ * wtf/MainThread.h:
+ * wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
+ (WTF::callOnMainThread):
+ (WTF::cancelCallOnMainThread):
+
+2015-08-21 Anders Carlsson <[email protected]>
+
Deprecate the old school callOnMainThread/cancelCallOnMainThread functions
https://bugs.webkit.org/show_bug.cgi?id=148327
Modified: trunk/Source/WTF/wtf/MainThread.h (188797 => 188798)
--- trunk/Source/WTF/wtf/MainThread.h 2015-08-21 23:34:07 UTC (rev 188797)
+++ trunk/Source/WTF/wtf/MainThread.h 2015-08-21 23:37:24 UTC (rev 188798)
@@ -36,7 +36,6 @@
namespace WTF {
typedef uint32_t ThreadIdentifier;
-typedef void MainThreadFunction(void*);
// Must be called from the main thread.
WTF_EXPORT_PRIVATE void initializeMainThread();
@@ -92,8 +91,8 @@
#endif
#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED == 1090
-WTF_EXPORT_PRIVATE void callOnMainThread(MainThreadFunction*, void* context);
-WTF_EXPORT_PRIVATE void cancelCallOnMainThread(MainThreadFunction*, void* context);
+WTF_EXPORT_PRIVATE void callOnMainThread(void (*function)(void*), void* context);
+WTF_EXPORT_PRIVATE void cancelCallOnMainThread(void (*function)(void*)*, void* context);
#endif
} // namespace WTF
Modified: trunk/Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm (188797 => 188798)
--- trunk/Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm 2015-08-21 23:34:07 UTC (rev 188797)
+++ trunk/Source/WTF/wtf/mac/DeprecatedSymbolsUsedBySafari.mm 2015-08-21 23:37:24 UTC (rev 188798)
@@ -63,8 +63,8 @@
}
#if __MAC_OS_X_VERSION_MIN_REQUIRED <= 101100
-WTF_EXPORT_PRIVATE void callOnMainThread(MainThreadFunction*, void* context);
-WTF_EXPORT_PRIVATE void cancelCallOnMainThread(MainThreadFunction*, void* context);
+WTF_EXPORT_PRIVATE void callOnMainThread(void (*function)(void*), void* context);
+WTF_EXPORT_PRIVATE void cancelCallOnMainThread(void (*function)(void*), void* context);
class MainThreadFunctionTracker {
public:
@@ -140,12 +140,12 @@
HashMap<std::pair<void (*)(void*), void*>, HashSet<uint64_t>> m_functions;
};
-void callOnMainThread(MainThreadFunction* function, void* context)
+void callOnMainThread(void (*function)(void*), void* context)
{
MainThreadFunctionTracker::singleton().callOnMainThread(function, context);
}
-void cancelCallOnMainThread(MainThreadFunction* function, void* context)
+void cancelCallOnMainThread(void (*function)(void*), void* context)
{
ASSERT(function);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
