Title: [188838] trunk/Tools
- Revision
- 188838
- Author
- a...@apple.com
- Date
- 2015-08-23 09:33:01 -0700 (Sun, 23 Aug 2015)
Log Message
build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
https://bugs.webkit.org/show_bug.cgi?id=148356
Reviewed by Darin Adler.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js (188837 => 188838)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js 2015-08-23 16:31:16 UTC (rev 188837)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js 2015-08-23 16:33:01 UTC (rev 188838)
@@ -106,14 +106,15 @@
if (firstRecentUnsuccessfulIteration && firstRecentUnsuccessfulIteration.loaded && mostRecentFinishedIteration && mostRecentFinishedIteration.loaded) {
console.assert(!mostRecentFinishedIteration.successful);
var message = this.revisionContentForIteration(mostRecentFinishedIteration, mostRecentFinishedIteration.productive ? mostRecentSuccessfulIteration : null);
- if (mostRecentFinishedIteration.failed) {
+ if (!mostRecentFinishedIteration.productive)
+ var status = StatusLineView.Status.Danger;
+ else {
// Direct links to some common logs.
var url = "" log");
if (!url)
url = ""
var status = StatusLineView.Status.Bad;
- } else
- var status = StatusLineView.Status.Danger;
+ }
// Show a popover when the URL is not a main build page one, because there are usually multiple logs, and it's good to provide a choice.
var needsPopover = !url;
Modified: trunk/Tools/ChangeLog (188837 => 188838)
--- trunk/Tools/ChangeLog 2015-08-23 16:31:16 UTC (rev 188837)
+++ trunk/Tools/ChangeLog 2015-08-23 16:33:01 UTC (rev 188838)
@@ -1,5 +1,15 @@
2015-08-23 Alexey Proskuryakov <a...@apple.com>
+ build.webkit.org/dashboard: Combined queues don't turn orange on internal failure
+ https://bugs.webkit.org/show_bug.cgi?id=148356
+
+ Reviewed by Darin Adler.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
+ (BuildbotCombinedQueueView.prototype.update):
+
+2015-08-23 Alexey Proskuryakov <a...@apple.com>
+
build.webkit.org/dashboard: Respect step's hidden flag
https://bugs.webkit.org/show_bug.cgi?id=148357
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
