Skip to site navigation (Press enter)

[webkit-changes] [188966] trunk

commit-queue Wed, 26 Aug 2015 08:54:11 -0700

Title: [188966] trunk

Revision: 188966
Author: [email protected]
Date: 2015-08-26 08:53:00 -0700 (Wed, 26 Aug 2015)

Log Message

Unreviewed, rolling out r188960.
https://bugs.webkit.org/show_bug.cgi?id=148479


Broke all the tests (Requested by ap on #webkit).

Reverted changeset:

"Add some new emoji with modifiers and new sequence."
https://bugs.webkit.org/show_bug.cgi?id=148202
http://trac.webkit.org/changeset/188960

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/deleting/delete-emoji-expected.txt
trunk/LayoutTests/editing/deleting/delete-emoji.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCascade.cpp
trunk/Source/WebCore/platform/text/CharacterProperties.h
trunk/Source/WebCore/platform/text/TextBreakIterator.cpp

Diff

Modified: trunk/LayoutTests/ChangeLog (188965 => 188966)


--- trunk/LayoutTests/ChangeLog	2015-08-26 14:34:38 UTC (rev 188965)
+++ trunk/LayoutTests/ChangeLog	2015-08-26 15:53:00 UTC (rev 188966)
@@ -1,3 +1,16 @@
+2015-08-26  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r188960.
+        https://bugs.webkit.org/show_bug.cgi?id=148479
+
+        Broke all the tests (Requested by ap on #webkit).
+
+        Reverted changeset:
+
+        "Add some new emoji with modifiers and new sequence."
+        https://bugs.webkit.org/show_bug.cgi?id=148202
+        http://trac.webkit.org/changeset/188960
+
 2015-08-25  Brian Burg  <[email protected]>
 
         Web Inspector: no need to allocate protocolErrors array for every dispatched backend command

Modified: trunk/LayoutTests/editing/deleting/delete-emoji-expected.txt (188965 => 188966)


--- trunk/LayoutTests/editing/deleting/delete-emoji-expected.txt	2015-08-26 14:34:38 UTC (rev 188965)
+++ trunk/LayoutTests/editing/deleting/delete-emoji-expected.txt	2015-08-26 15:53:00 UTC (rev 188966)
@@ -1,65 +1,38 @@
 This test verifies that emoji groups and emoji with variations are deleted correctly
 
 Dump of markup 1:
-| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻✍🏾⛹🏾🖐🏾🖕🏾🤘🏾🕵🏾🕴🏾🏋🏾👁‍🗨<#selection-caret>
+| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻<#selection-caret>
 "
 
 Dump of markup 2:
-| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻✍🏾⛹🏾🖐🏾🖕🏾🤘🏾🕵🏾🕴🏾🏋🏾<#selection-caret>"
-
-Dump of markup 3:
-| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻✍🏾⛹🏾🖐🏾🖕🏾🤘🏾🕵🏾🕴🏾<#selection-caret>"
-
-Dump of markup 4:
-| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻✍🏾⛹🏾🖐🏾🖕🏾🤘🏾🕵🏾<#selection-caret>"
-
-Dump of markup 5:
-| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻✍🏾⛹🏾🖐🏾🖕🏾🤘🏾<#selection-caret>"
-
-Dump of markup 6:
-| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻✍🏾⛹🏾🖐🏾🖕🏾<#selection-caret>"
-
-Dump of markup 7:
-| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻✍🏾⛹🏾🖐🏾<#selection-caret>"
-
-Dump of markup 8:
-| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻✍🏾⛹🏾<#selection-caret>"
-
-Dump of markup 9:
-| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻✍🏾<#selection-caret>"
-
-Dump of markup 10:
-| "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨☝️🏻<#selection-caret>"
-
-Dump of markup 11:
 | "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩👨‍❤️‍💋‍👨<#selection-caret>"
 
-Dump of markup 12:
+Dump of markup 3:
 | "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨👩‍❤️‍💋‍👩<#selection-caret>"
 
-Dump of markup 13:
+Dump of markup 4:
 | "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩👨‍❤️‍👨<#selection-caret>"
 
-Dump of markup 14:
+Dump of markup 5:
 | "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦👩‍❤️‍👩<#selection-caret>"
 
-Dump of markup 15:
+Dump of markup 6:
 | "👦🏻👦🏾🏻👦🏾👦👩‍👩‍👦<#selection-caret>"
 
-Dump of markup 16:
+Dump of markup 7:
 | "👦🏻👦🏾🏻👦🏾👦<#selection-caret>"
 
-Dump of markup 17:
+Dump of markup 8:
 | "👦🏻👦🏾🏻👦🏾<#selection-caret>"
 
-Dump of markup 18:
+Dump of markup 9:
 | "👦🏻👦🏾🏻<#selection-caret>"
 
-Dump of markup 19:
+Dump of markup 10:
 | "👦🏻👦🏾<#selection-caret>"
 
-Dump of markup 20:
+Dump of markup 11:
 | "👦🏻<#selection-caret>"
 
-Dump of markup 21:
+Dump of markup 12:
 | <br>

Modified: trunk/LayoutTests/editing/deleting/delete-emoji.html (188965 => 188966)


--- trunk/LayoutTests/editing/deleting/delete-emoji.html	2015-08-26 14:34:38 UTC (rev 188965)
+++ trunk/LayoutTests/editing/deleting/delete-emoji.html	2015-08-26 15:53:00 UTC (rev 188966)
@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <html>
 <body>
-<div id="test" contenteditable="true">&#x1F466;&#x1F3FB;&#x1F466;&#x1F3FE;&#x1F3FB;&#x1F466;&#x1F3FE;&#x1F466;&#x1F469;&#x200D;&#x1F469;&#x200D;&#x1F466;&#x1F469;&#x200D;&#x2764;&#xFE0F;&#x200D;&#x1F469;&#x1F468;&#x200D;&#x2764;&#xFE0F;&#x200D;&#x1F468;&#x1F469;&#x200D;&#x2764;&#xFE0F;&#x200D;&#x1F48B;&#x200D;&#x1F469;&#x1F468;&#x200D;&#x2764;&#xFE0F;&#x200D;&#x1F48B;&#x200D;&#x1F468;&#x261D;&#xFE0F;&#x1F3FB;&#x270D;&#x1F3FE;&#x26F9;&#x1F3FE;&#x1F590;&#x1F3FE;&#x1F595;&#x1F3FE;&#x1F918;&#x1F3FE;&#x1F575;&#x1F3FE;&#x1F574;&#x1F3FE;&#x1F3CB;&#x1F3FE;&#x1F441;&#x200D;&#x1F5E8;
+<div id="test" contenteditable="true">&#x1F466;&#x1F3FB;&#x1F466;&#x1F3FE;&#x1F3FB;&#x1F466;&#x1F3FE;&#x1F466;&#x1F469;&#x200D;&#x1F469;&#x200D;&#x1F466;&#x1F469;&#x200D;&#x2764;&#xFE0F;&#x200D;&#x1F469;&#x1F468;&#x200D;&#x2764;&#xFE0F;&#x200D;&#x1F468;&#x1F469;&#x200D;&#x2764;&#xFE0F;&#x200D;&#x1F48B;&#x200D;&#x1F469;&#x1F468;&#x200D;&#x2764;&#xFE0F;&#x200D;&#x1F48B;&#x200D;&#x1F468;&#x261D;&#xFE0F;&#x1F3FB;
 </div>
 <script src=""
 <script>

Modified: trunk/Source/WebCore/ChangeLog (188965 => 188966)


--- trunk/Source/WebCore/ChangeLog	2015-08-26 14:34:38 UTC (rev 188965)
+++ trunk/Source/WebCore/ChangeLog	2015-08-26 15:53:00 UTC (rev 188966)
@@ -1,3 +1,16 @@
+2015-08-26  Commit Queue  <[email protected]>
+
+        Unreviewed, rolling out r188960.
+        https://bugs.webkit.org/show_bug.cgi?id=148479
+
+        Broke all the tests (Requested by ap on #webkit).
+
+        Reverted changeset:
+
+        "Add some new emoji with modifiers and new sequence."
+        https://bugs.webkit.org/show_bug.cgi?id=148202
+        http://trac.webkit.org/changeset/188960
+
 2015-08-25  Philippe Normand  <[email protected]>
 
         [GStreamer] "method" property for the webkitwebsrc element

Modified: trunk/Source/WebCore/platform/graphics/FontCascade.cpp (188965 => 188966)


--- trunk/Source/WebCore/platform/graphics/FontCascade.cpp	2015-08-26 14:34:38 UTC (rev 188965)
+++ trunk/Source/WebCore/platform/graphics/FontCascade.cpp	2015-08-26 15:53:00 UTC (rev 188966)
@@ -751,7 +751,7 @@
             if (supplementaryCharacter <= 0x1F1FF)
                 return Complex;
 
-            if (supplementaryCharacter == 0x1F441 || supplementaryCharacter == 0x1F5E8 || (supplementaryCharacter >= 0x1F466 && supplementaryCharacter <= 0x1F469)) {
+            if (supplementaryCharacter >= 0x1F466 && supplementaryCharacter <= 0x1F469) {
                 previousCharacterIsEmojiGroupCandidate = true;
                 continue;
             }

Modified: trunk/Source/WebCore/platform/text/CharacterProperties.h (188965 => 188966)


--- trunk/Source/WebCore/platform/text/CharacterProperties.h	2015-08-26 14:34:38 UTC (rev 188965)
+++ trunk/Source/WebCore/platform/text/CharacterProperties.h	2015-08-26 15:53:00 UTC (rev 188966)
@@ -30,8 +30,7 @@
 
 static inline bool isEmojiGroupCandidate(UChar32 character)
 {
-    return (character >= 0x1F466 && character <= 0x1F469) || character == 0x2764 || character == 0x1F48B
-        || character == 0x1F441 || character == 0x1F5E8;
+    return (character >= 0x1F466 && character <= 0x1F469) || character == 0x2764 || character == 0x1F48B;
 }
 
 static inline bool isEmojiModifier(UChar32 character)

Modified: trunk/Source/WebCore/platform/text/TextBreakIterator.cpp (188965 => 188966)


--- trunk/Source/WebCore/platform/text/TextBreakIterator.cpp	2015-08-26 14:34:38 UTC (rev 188965)
+++ trunk/Source/WebCore/platform/text/TextBreakIterator.cpp	2015-08-26 15:53:00 UTC (rev 188966)
@@ -210,20 +210,19 @@
         "$RI      = [\\U0001F1E6-\\U0001F1FF];" // Emoji regional indicators
         "$ZWJ     = \\u200D;"               // Zero width joiner
         "$EmojiVar = [\\uFE0F];"            // Emoji-style variation selector
-        "$EmojiForSeqs = [\\u2764 \\U0001F441 \\U0001F466-\\U0001F469 \\U0001F48B \\U0001F5E8];" // Emoji that participate in ZWJ sequences
-        "$EmojiForMods = [\\u261D \\u26F9 \\u270A-\\u270D \\U0001F385 \\U0001F3C3-\\U0001F3C4 \\U0001F3C7 \\U0001F3CA \\U0001F3CB \\U0001F442-\\U0001F443 \\U0001F446-\\U0001F450 \\U0001F466-\\U0001F469 \\U0001F46E-\\U0001F478 \\U0001F47C \\U0001F481-\\U0001F483 \\U0001F485-\\U0001F487 \\U0001F4AA \\U0001F590 \\U0001F595 \\U0001F596 \\U0001F645-\\U0001F647 \\U0001F64B-\\U0001F64F \\U0001F6A3 \\U0001F6B4-\\U0001F6B6 \\U0001F6C0 \\U0001F918] ;" // Emoji that take Fitzpatrick modifiers
+        "$EmojiForSeqs = [\\u2764 \\U0001F466-\\U0001F469 \\U0001F48B];" // Emoji that participate in ZWJ sequences
+        "$EmojiForMods = [\\u261D \\u270A-\\u270C \\U0001F385 \\U0001F3C3-\\U0001F3C4 \\U0001F3C7 \\U0001F3CA \\U0001F442-\\U0001F443 \\U0001F446-\\U0001F450 \\U0001F466-\\U0001F469 \\U0001F46E-\\U0001F478 \\U0001F47C \\U0001F481-\\U0001F483 \\U0001F485-\\U0001F487 \\U0001F4AA \\U0001F596 \\U0001F645-\\U0001F647 \\U0001F64B-\\U0001F64F \\U0001F6A3 \\U0001F6B4-\\U0001F6B6 \\U0001F6C0] ;" // Emoji that take Fitzpatrick modifiers
         "$EmojiMods = [\\U0001F3FB-\\U0001F3FF];" // Fitzpatrick modifiers
         "!!chain;"
-        "!!RINoChain;"
         "!!forward;"
         "$CR $LF;"
         "$L ($L | $V | $LV | $LVT);"
         "($LV | $V) ($V | $T);"
         "($LVT | $T) $T;"
-        "$RI $RI $Extend* / $RI;"
-        "$RI $RI $Extend*;"
         "[^$Control $CR $LF] $Extend;"
         "[^$Control $CR $LF] $SpacingMark;"
+        "$RI $RI / $RI;"
+        "$RI $RI;"
         "$Hin0 $HinV $Hin1;"               // Devanagari Virama (forward)
         "$Ben0 $BenV $Ben1;"               // Bengali Virama (forward)
         "$Pan0 $PanV $Pan1;"               // Gurmukhi Virama (forward)
@@ -239,10 +238,10 @@
         "($L | $V | $LV | $LVT) $L;"
         "($V | $T) ($LV | $V);"
         "$T ($LVT | $T);"
-        "$Extend* $RI $RI / $Extend* $RI $RI;"
-        "$Extend* $RI $RI;"
         "$Extend      [^$Control $CR $LF];"
         "$SpacingMark [^$Control $CR $LF];"
+        "$RI $RI / $RI $RI;"
+        "$RI $RI;"
         "$Hin1 $HinV $Hin0;"               // Devanagari Virama (backward)
         "$Ben1 $BenV $Ben0;"               // Bengali Virama (backward)
         "$Pan1 $PanV $Pan0;"               // Gurmukhi Virama (backward)
@@ -253,12 +252,10 @@
         "$Mal1 $MalV $Mal0;"               // Malayalam Virama (backward)
         "$EmojiForSeqs $ZWJ;"              // Don't break in emoji ZWJ sequences
         "$EmojiMods $EmojiVar? $EmojiForMods;" // Don't break between relevant emoji (possibly with variation selector) and Fitzpatrick modifier
-        "!!safe_reverse;"
-        "$RI $RI+;"
         "[$EmojiVar $EmojiMods]+ $EmojiForMods;"
-        "!!safe_forward;"
-        "$RI $RI+;"
-        "$EmojiForMods [$EmojiVar $EmojiMods]+;";
+        "$EmojiForMods [$EmojiVar $EmojiMods]+;"
+        "!!safe_reverse;"
+        "!!safe_forward;";
     static TextBreakIterator* staticCursorMovementIterator = initializeIteratorWithRules(kRules);
 #else // PLATFORM(IOS)
     // Use the special Thai character break iterator for all locales
@@ -405,7 +402,6 @@
     "$PO = [[:LineBreak = Postfix_Numeric:] - $PO_SUB];"
     "$PR = [[:LineBreak = Prefix_Numeric:] - $PR_SUB];"
     "$QU = [:LineBreak = Quotation:];"
-    "$RI = [\\U0001F1E6-\\U0001F1FF];"
     "$SA = [:LineBreak = Complex_Context:];"
     "$SG = [:LineBreak = Surrogate:];"
     "$SP = [:LineBreak = Space:];"
@@ -415,8 +411,8 @@
     "$ZW = [:LineBreak = ZWSpace:];"
     "$ZWJ = \\u200D;"
     "$EmojiVar = \\uFE0F;"
-    "$EmojiForSeqs = [\\u2764 \\U0001F441 \\U0001F466-\\U0001F469 \\U0001F48B \\U0001F5E8];"
-    "$EmojiForMods = [\\u261D \\u26F9 \\u270A-\\u270D \\U0001F385 \\U0001F3C3-\\U0001F3C4 \\U0001F3C7 \\U0001F3CA \\U0001F3CB \\U0001F442-\\U0001F443 \\U0001F446-\\U0001F450 \\U0001F466-\\U0001F469 \\U0001F46E-\\U0001F478 \\U0001F47C \\U0001F481-\\U0001F483 \\U0001F485-\\U0001F487 \\U0001F4AA \\U0001F590 \\U0001F595 \\U0001F596 \\U0001F645-\\U0001F647 \\U0001F64B-\\U0001F64F \\U0001F6A3 \\U0001F6B4-\\U0001F6B6 \\U0001F6C0 \\U0001F918] ;" // Emoji that take Fitzpatrick modifiers
+    "$EmojiForSeqs = [\\u2764 \\U0001F466-\\U0001F469 \\U0001F48B];"
+    "$EmojiForMods = [\\u261D \\u270A-\\u270C \\U0001F385 \\U0001F3C3-\\U0001F3C4 \\U0001F3C7 \\U0001F3CA \\U0001F442-\\U0001F443 \\U0001F446-\\U0001F450 \\U0001F466-\\U0001F469 \\U0001F46E-\\U0001F478 \\U0001F47C \\U0001F481-\\U0001F483 \\U0001F485-\\U0001F487 \\U0001F4AA \\U0001F596 \\U0001F645-\\U0001F647 \\U0001F64B-\\U0001F64F \\U0001F6A3 \\U0001F6B4-\\U0001F6B6 \\U0001F6C0] ;" // Emoji that take Fitzpatrick modifiers
     "$EmojiMods = [\\U0001F3FB-\\U0001F3FF];"
     "$dictionary = [:LineBreak = Complex_Context:];"
     "$ALPlus = [$AL $AI $SA $SG $XX];"
@@ -444,7 +440,6 @@
     "$POcm = $PO $CM*;"
     "$PRcm = $PR $CM*;"
     "$QUcm = $QU $CM*;"
-    "$RIcm = $QU $CM*;"
     "$SYcm = $SY $CM*;"
     "$WJcm = $WJ $CM*;";
 
@@ -563,7 +558,6 @@
     "($ALcm | $HLcm | $NUcm) $OPcm;"
     "$CM+ $OPcm;"
     "$CPcm ($ALcm | $HLcm | $NUcm);"
-    "$RIcm $RIcm;"
     "$EmojiForMods $EmojiVar? $EmojiMods;";
 
 static const char* uax14Reverse =
@@ -592,7 +586,6 @@
     "$CM+ $PO;"
     "$CM+ $PR;"
     "$CM+ $QU;"
-    "$CM+ $RI;"
     "$CM+ $SY;"
     "$CM+ $WJ;"
     "$CM+;"
@@ -661,7 +654,6 @@
     "$CM* ($ALPlus | $HL) $CM* $IS;"
     "$CM* $OP $CM* ($ALPlus | $HL | $NU);"
     "$CM* ($ALPlus | $HL | $NU) $CM* $CP;"
-    "$CM* $RI $CM* $RI;"
     "$EmojiMods $EmojiVar? $EmojiForMods;";
 
 static const char* uax14SafeForward =

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes