Title: [189011] trunk/Source/WebInspectorUI
- Revision
- 189011
- Author
- [email protected]
- Date
- 2015-08-26 21:40:50 -0700 (Wed, 26 Aug 2015)
Log Message
Web Inspector: [Regression] [Mavericks]: Undocked Web Inspector toolbar is two different colors and has extra space
https://bugs.webkit.org/show_bug.cgi?id=148510
Make body element transparent and remove extra padding above the toolbar only for OS X Mavericks.
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
* UserInterface/Views/Main.css:
(body:not(.mavericks)):
(body): Deleted.
* UserInterface/Views/Toolbar.css:
(body:not(.mavericks) .toolbar):
(body.window-inactive:not(.mavericks) .toolbar):
(body.mac-platform:not(.docked, .mavericks) .toolbar):
(.toolbar): Deleted.
(body.window-inactive .toolbar): Deleted.
(body.mac-platform:not(.docked) .toolbar): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (189010 => 189011)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-27 03:32:12 UTC (rev 189010)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-27 04:40:50 UTC (rev 189011)
@@ -1,3 +1,25 @@
+2015-08-26 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: [Regression] [Mavericks]: Undocked Web Inspector toolbar is two different colors and has extra space
+ https://bugs.webkit.org/show_bug.cgi?id=148510
+
+ Make body element transparent and remove extra padding above the toolbar only for OS X Mavericks.
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.contentLoaded):
+ * UserInterface/Views/Main.css:
+ (body:not(.mavericks)):
+ (body): Deleted.
+ * UserInterface/Views/Toolbar.css:
+ (body:not(.mavericks) .toolbar):
+ (body.window-inactive:not(.mavericks) .toolbar):
+ (body.mac-platform:not(.docked, .mavericks) .toolbar):
+ (.toolbar): Deleted.
+ (body.window-inactive .toolbar): Deleted.
+ (body.mac-platform:not(.docked) .toolbar): Deleted.
+
2015-08-26 Joseph Pecoraro <[email protected]>
Web Inspector: Uncaught exception in CSS Completion - TypeError: undefined is not an object (evaluating 'this._values[middleIndex].startsWith')
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (189010 => 189011)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-08-27 03:32:12 UTC (rev 189010)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-08-27 04:40:50 UTC (rev 189011)
@@ -195,6 +195,8 @@
document.body.classList.add("nightly-build");
if (WebInspector.Platform.name === "mac") {
+ document.body.classList.add(WebInspector.Platform.version.name);
+
if (WebInspector.Platform.version.release >= 11)
document.body.classList.add("latest-mac");
else
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Main.css (189010 => 189011)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2015-08-27 03:32:12 UTC (rev 189010)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Main.css 2015-08-27 04:40:50 UTC (rev 189011)
@@ -34,8 +34,6 @@
font-family: -apple-system, sans-serif;
font-size: 11px;
- background-color: white;
-
position: absolute;
top: 0;
left: 0;
@@ -57,6 +55,10 @@
tab-size: 4; /* FIXME: This should be controlled by a setting. <rdar://problem/10593948> */
}
+body:not(.mavericks) {
+ background-color: white;
+}
+
body.docked.bottom {
border-top: 1px solid hsl(0, 0%, 78%);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (189010 => 189011)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css 2015-08-27 03:32:12 UTC (rev 189010)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css 2015-08-27 04:40:50 UTC (rev 189011)
@@ -29,9 +29,6 @@
white-space: nowrap;
overflow: hidden;
- background-image: linear-gradient(to bottom, hsl(0, 0%, 92%), hsl(0, 0%, 87%));
- box-shadow: inset hsla(0, 0%, 100%, 0.5) 0 1px 1px;
-
outline: none;
padding-top: 3px;
@@ -39,12 +36,17 @@
height: 36px;
}
-body.window-inactive .toolbar {
+body:not(.mavericks) .toolbar {
+ background-image: linear-gradient(to bottom, hsl(0, 0%, 92%), hsl(0, 0%, 87%));
+ box-shadow: inset hsla(0, 0%, 100%, 0.5) 0 1px 1px;
+}
+
+body.window-inactive:not(.mavericks) .toolbar {
background-image: none;
background-color: hsl(0, 0%, 96%);
}
-body.mac-platform:not(.docked) .toolbar {
+body.mac-platform:not(.docked, .mavericks) .toolbar {
padding-top: 21px;
height: 54px;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
