Title: [189073] trunk/LayoutTests
- Revision
- 189073
- Author
- [email protected]
- Date
- 2015-08-27 16:52:26 -0700 (Thu, 27 Aug 2015)
Log Message
fast/css/object-fit/object-fit-embed.html isn't testing anything
https://bugs.webkit.org/show_bug.cgi?id=148512
Reviewed by Andy Estes.
* fast/css/object-fit/object-fit-embed-expected.html:
* fast/css/object-fit/object-fit-embed.html:
* fast/replaced/border-radius-clip-content-edge.html:
* fast/replaced/outline-replaced-elements.html:
These tests load PNGs inside <embeds>. r82001 made it so that
the test plugin handles PNGs, and also so that <embed> prefers
plugins even for types that we know how to handle natively.
Since these tests actually want to load PNGs natively, disable
plugins so we don't get that behavior.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (189072 => 189073)
--- trunk/LayoutTests/ChangeLog 2015-08-27 23:50:55 UTC (rev 189072)
+++ trunk/LayoutTests/ChangeLog 2015-08-27 23:52:26 UTC (rev 189073)
@@ -1,3 +1,21 @@
+2015-08-27 Tim Horton <[email protected]>
+
+ fast/css/object-fit/object-fit-embed.html isn't testing anything
+ https://bugs.webkit.org/show_bug.cgi?id=148512
+
+ Reviewed by Andy Estes.
+
+ * fast/css/object-fit/object-fit-embed-expected.html:
+ * fast/css/object-fit/object-fit-embed.html:
+ * fast/replaced/border-radius-clip-content-edge.html:
+ * fast/replaced/outline-replaced-elements.html:
+ These tests load PNGs inside <embeds>. r82001 made it so that
+ the test plugin handles PNGs, and also so that <embed> prefers
+ plugins even for types that we know how to handle natively.
+
+ Since these tests actually want to load PNGs natively, disable
+ plugins so we don't get that behavior.
+
2015-08-27 Keith Miller <[email protected]>
[ES6] Add TypedArray.prototype functionality.
Modified: trunk/LayoutTests/fast/css/object-fit/object-fit-embed-expected.html (189072 => 189073)
--- trunk/LayoutTests/fast/css/object-fit/object-fit-embed-expected.html 2015-08-27 23:50:55 UTC (rev 189072)
+++ trunk/LayoutTests/fast/css/object-fit/object-fit-embed-expected.html 2015-08-27 23:52:26 UTC (rev 189073)
@@ -23,6 +23,11 @@
.group > *:nth-child(6) * { width:100%; margin-top:25%; }
.group > *:nth-child(7) * { width:100%; height:100%; }
</style>
+ <script>
+ // Disable plugins, because otherwise the "Test WebKit PlugIn" steals <embed>s referencing PNGs.
+ if (window.testRunner)
+ testRunner.setPluginsEnabled(false);
+ </script>
</head>
<body>
Modified: trunk/LayoutTests/fast/css/object-fit/object-fit-embed.html (189072 => 189073)
--- trunk/LayoutTests/fast/css/object-fit/object-fit-embed.html 2015-08-27 23:50:55 UTC (rev 189072)
+++ trunk/LayoutTests/fast/css/object-fit/object-fit-embed.html 2015-08-27 23:52:26 UTC (rev 189073)
@@ -21,6 +21,11 @@
.group > *:nth-child(6) { object-fit: inherit; }
.group > *:nth-child(7) { }
</style>
+ <script>
+ // Disable plugins, because otherwise the "Test WebKit PlugIn" steals <embed>s referencing PNGs.
+ if (window.testRunner)
+ testRunner.setPluginsEnabled(false);
+ </script>
</head>
<body>
Modified: trunk/LayoutTests/fast/replaced/border-radius-clip-content-edge.html (189072 => 189073)
--- trunk/LayoutTests/fast/replaced/border-radius-clip-content-edge.html 2015-08-27 23:50:55 UTC (rev 189072)
+++ trunk/LayoutTests/fast/replaced/border-radius-clip-content-edge.html 2015-08-27 23:52:26 UTC (rev 189073)
@@ -32,6 +32,12 @@
<body>
<!-- Replaced elements with border-radius should clip to the content edge curve. -->
+<script>
+// Disable plugins, because otherwise the "Test WebKit PlugIn" steals <embed>s referencing PNGs.
+if (window.testRunner)
+ testRunner.setPluginsEnabled(false);
+</script>
+
<div>
<object data=""
</div>
Modified: trunk/LayoutTests/fast/replaced/outline-replaced-elements.html (189072 => 189073)
--- trunk/LayoutTests/fast/replaced/outline-replaced-elements.html 2015-08-27 23:50:55 UTC (rev 189072)
+++ trunk/LayoutTests/fast/replaced/outline-replaced-elements.html 2015-08-27 23:52:26 UTC (rev 189073)
@@ -19,6 +19,9 @@
if (window.testRunner) {
var dumpPixelResults = true;
testRunner.dumpAsText(dumpPixelResults);
+
+ // Disable plugins, because otherwise the "Test WebKit PlugIn" steals <embed>s referencing PNGs.
+ testRunner.setPluginsEnabled(false);
}
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
