Title: [189106] trunk/Tools
- Revision
- 189106
- Author
- [email protected]
- Date
- 2015-08-28 11:13:37 -0700 (Fri, 28 Aug 2015)
Log Message
The status message for combined builder queues should say "all builds succeeded" if everything
built correctly.
https://bugs.webkit.org/show_bug.cgi?id=148535
Patch by Jason Marcell <[email protected]> on 2015-08-28
Reviewed by David Kilzer and Alexey Proskuryakov.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
(BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
say "all builds succeeded" if everything built correctly.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js (189105 => 189106)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js 2015-08-28 18:09:49 UTC (rev 189105)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js 2015-08-28 18:13:37 UTC (rev 189106)
@@ -87,7 +87,8 @@
this._appendPendingRevisionCount(slowestQueue);
var message = this.revisionContentForIteration(slowestQueue.mostRecentSuccessfulIteration);
- var status = new StatusLineView(message, StatusLineView.Status.Good, "all tests passed", null, null);
+ var statusMessagePassed = "all " + (queue.builder ? "builds succeeded" : "tests passed");
+ var status = new StatusLineView(message, StatusLineView.Status.Good, statusMessagePassed, null, null);
new PopoverTracker(status.statusBubbleElement, this._presentPopoverForCombinedGreenBubble.bind(this));
this.element.appendChild(status.element);
} else {
Modified: trunk/Tools/ChangeLog (189105 => 189106)
--- trunk/Tools/ChangeLog 2015-08-28 18:09:49 UTC (rev 189105)
+++ trunk/Tools/ChangeLog 2015-08-28 18:13:37 UTC (rev 189106)
@@ -1,3 +1,15 @@
+2015-08-28 Jason Marcell <[email protected]>
+
+ The status message for combined builder queues should say "all builds succeeded" if everything
+ built correctly.
+ https://bugs.webkit.org/show_bug.cgi?id=148535
+
+ Reviewed by David Kilzer and Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
+ (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
+ say "all builds succeeded" if everything built correctly.
+
2015-08-28 Carlos Garcia Campos <[email protected]>
[GTK] Simplify the internal API to create a WebView
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
