Title: [189142] trunk/Source/WebInspectorUI
- Revision
- 189142
- Author
- [email protected]
- Date
- 2015-08-28 22:05:24 -0700 (Fri, 28 Aug 2015)
Log Message
Web Inspector: "animationEnd" event names should be "animationend" (broken dashboard animation after pause)
https://bugs.webkit.org/show_bug.cgi?id=148604
Patch by Joseph Pecoraro <[email protected]> on 2015-08-28
Reviewed by Timothy Hatcher.
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
* UserInterface/Views/DashboardContainerView.js:
(WebInspector.DashboardContainerView.prototype._showDashboardView.animationEnded):
(WebInspector.DashboardContainerView.prototype._showDashboardView):
(WebInspector.DashboardContainerView.prototype._hideDashboardView.animationEnded):
(WebInspector.DashboardContainerView.prototype._hideDashboardView):
* UserInterface/Views/DefaultDashboardView.js:
(WebInspector.DefaultDashboardView.prototype._setConsoleItemValue.animationEnded):
(WebInspector.DefaultDashboardView.prototype._setConsoleItemValue):
* UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype._revealSearchResult):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (189141 => 189142)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-29 03:30:31 UTC (rev 189141)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-29 05:05:24 UTC (rev 189142)
@@ -1,5 +1,25 @@
2015-08-28 Joseph Pecoraro <[email protected]>
+ Web Inspector: "animationEnd" event names should be "animationend" (broken dashboard animation after pause)
+ https://bugs.webkit.org/show_bug.cgi?id=148604
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/DOMTreeElement.js:
+ (WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
+ * UserInterface/Views/DashboardContainerView.js:
+ (WebInspector.DashboardContainerView.prototype._showDashboardView.animationEnded):
+ (WebInspector.DashboardContainerView.prototype._showDashboardView):
+ (WebInspector.DashboardContainerView.prototype._hideDashboardView.animationEnded):
+ (WebInspector.DashboardContainerView.prototype._hideDashboardView):
+ * UserInterface/Views/DefaultDashboardView.js:
+ (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue.animationEnded):
+ (WebInspector.DefaultDashboardView.prototype._setConsoleItemValue):
+ * UserInterface/Views/TextEditor.js:
+ (WebInspector.TextEditor.prototype._revealSearchResult):
+
+2015-08-28 Joseph Pecoraro <[email protected]>
+
Web Inspector: Resource.prototype.associateWithScript assertions firing
https://bugs.webkit.org/show_bug.cgi?id=148601
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (189141 => 189142)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2015-08-29 03:30:31 UTC (rev 189141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js 2015-08-29 05:05:24 UTC (rev 189142)
@@ -99,7 +99,7 @@
this._bouncyHighlightElement = null;
}
- this._bouncyHighlightElement.addEventListener("animationEnd", animationEnded.bind(this));
+ this._bouncyHighlightElement.addEventListener("animationend", animationEnded.bind(this));
}
_updateSearchHighlight(show)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.js (189141 => 189142)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.js 2015-08-29 03:30:31 UTC (rev 189141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DashboardContainerView.js 2015-08-29 05:05:24 UTC (rev 189142)
@@ -190,14 +190,14 @@
if (event.target !== dashboardView.element)
return;
- dashboardView.element.removeEventListener("animationEnd", animationEnded);
+ dashboardView.element.removeEventListener("animationend", animationEnded);
dashboardView.element.classList.remove(animationClass);
container._updateAdvanceArrowVisibility();
}
if (animationClass) {
dashboardView.element.classList.add(animationClass);
- dashboardView.element.addEventListener("animationEnd", animationEnded);
+ dashboardView.element.addEventListener("animationend", animationEnded);
}
return dashboardView;
@@ -223,7 +223,7 @@
if (event.target !== dashboardView.element)
return;
- dashboardView.element.removeEventListener("animationEnd", animationEnded);
+ dashboardView.element.removeEventListener("animationend", animationEnded);
dashboardView.element.classList.remove(animationClass);
dashboardView.element.classList.remove(WebInspector.DashboardContainerView.VisibleDashboardStyleClassName);
container._updateAdvanceArrowVisibility();
@@ -234,7 +234,7 @@
if (animationClass) {
dashboardView.element.classList.add(animationClass);
- dashboardView.element.addEventListener("animationEnd", animationEnded);
+ dashboardView.element.addEventListener("animationend", animationEnded);
} else
dashboardView.element.classList.remove(WebInspector.DashboardContainerView.VisibleDashboardStyleClassName);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js (189141 => 189142)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js 2015-08-29 03:30:31 UTC (rev 189141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js 2015-08-29 05:05:24 UTC (rev 189142)
@@ -164,7 +164,7 @@
{
if (event.target === container) {
container.classList.remove("pulsing");
- container.removeEventListener("animationEnd", animationEnded);
+ container.removeEventListener("animationend", animationEnded);
}
}
@@ -174,7 +174,7 @@
container.classList.remove("pulsing");
container.recalculateStyles();
} else
- container.addEventListener("animationEnd", animationEnded);
+ container.addEventListener("animationend", animationEnded);
container.classList.add("pulsing");
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (189141 => 189142)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2015-08-29 03:30:31 UTC (rev 189141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2015-08-29 05:05:24 UTC (rev 189142)
@@ -960,7 +960,7 @@
}
// Listen for the end of the animation so we can remove the element.
- this._bouncyHighlightElement.addEventListener("animationEnd", animationEnded.bind(this));
+ this._bouncyHighlightElement.addEventListener("animationend", animationEnded.bind(this));
}
_binarySearchInsertionIndexInSearchResults(object, comparator)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
