Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (189219 => 189220)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-09-01 18:38:09 UTC (rev 189220)
@@ -1,3 +1,53 @@
+2015-09-01 Devin Rousso <drou...@apple.com>
+
+ Web Inspector: New rule button in the style sidebar is blurry and too dark
+ https://bugs.webkit.org/show_bug.cgi?id=148108
+
+ Reviewed by Timothy Hatcher.
+
+ Added support for Plus and Minus icons on non-retina screens.
+ Also removed some CSS rules that no longer apply to anything.
+
+ * UserInterface/Images/Minus.svg:
+ * UserInterface/Images/NewTabPlus.svg:
+ * UserInterface/Images/Plus.svg: Removed.
+ * UserInterface/Images/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/Plus.svg.
+ * UserInterface/Images/Plus15.svg: Copied from Source/WebInspectorUI/UserInterface/Images/Plus.svg.
+
+ * UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
+ (.sidebar > .panel.details.css-style > .content + .options-container):
+ (.sidebar > .panel.details.css-style > .content + .options-container > .new-rule):
+
+ * UserInterface/Views/ProbeDetailsSidebarPanel.css:
+ (.details-section.probe-set .options > .probe-add):
+
+ * UserInterface/Views/RulesStyleDetailsPanel.css:
+ (.sidebar > .panel.details.css-style .rules .new-rule): Deleted.
+ (.sidebar > .panel.details.css-style .rules > *:first-child:matches(.new-rule)): Deleted.
+ (.sidebar > .panel.details.css-style > .content.filter-in-progress .new-rule): Deleted.
+ (.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .style-declaration-section): Deleted.
+ (.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .label): Deleted.
+ (.sidebar > .panel.details.css-style .rules .new-rule img): Deleted.
+ (.sidebar > .panel.details.css-style .rules .new-rule:hover): Deleted.
+ (.sidebar > .panel.details.css-style .rules .new-rule:active): Deleted.
+ (@media (-webkit-min-device-pixel-ratio: 2)): Deleted.
+ Removed CSS rules that no longer apply. The new rule button was moved to the Styles sidebar.
+
+ * UserInterface/Views/ScopeChainDetailsSidebarPanel.css:
+ (.details-section.watch-expressions .options > .watch-_expression_-add):
+
+ * UserInterface/Views/TabBar.css:
+ (.tab-bar > .item.new-tab-button > .icon):
+
+ * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
+ (.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-controls > div):
+
+ * UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js:
+ (WebInspector.VisualStyleCommaSeparatedKeywordEditor):
+
+ * UserInterface/Views/VisualStyleSelectorSection.js:
+ (WebInspector.VisualStyleSelectorSection):
+
2015-09-01 Brian Burg <bb...@apple.com>
Web Inspector: add TestSuite hooks for per-testcase setup and teardown actions
Modified: trunk/Source/WebInspectorUI/UserInterface/Images/Minus.svg (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Images/Minus.svg 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/Minus.svg 2015-09-01 18:38:09 UTC (rev 189220)
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright © 2015 Apple Inc. All rights reserved. -->
<svg version="1.1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 13 13">
- <line class="stroked" fill="none" stroke="black" x1="1.5" y1="6.5" x2="11.5" y2="6.5"/>
+ <line class="stroked" fill="none" stroke="black" x1="1" y1="6.5" x2="12" y2="6.5"/>
</svg>
Modified: trunk/Source/WebInspectorUI/UserInterface/Images/NewTabPlus.svg (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Images/NewTabPlus.svg 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/NewTabPlus.svg 2015-09-01 18:38:09 UTC (rev 189220)
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright © 2015 Apple Inc. All rights reserved. -->
-<svg viewBox="0 0 16 16" version="1.1" xmlns="http://www.w3.org/2000/svg">
- <path d="M 8 2 L 8 14 M 2 8 L 14 8" class="stroked" fill="none" stroke="black"/>
+<svg viewBox="0 0 15 15" version="1.1" xmlns="http://www.w3.org/2000/svg">
+ <path d="M 7.5 2 V 13 M 2 7.5 H 13" class="stroked" fill="none" stroke="black"/>
</svg>
Deleted: trunk/Source/WebInspectorUI/UserInterface/Images/Plus.svg (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Images/Plus.svg 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/Plus.svg 2015-09-01 18:38:09 UTC (rev 189220)
@@ -1,5 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<!-- Copyright © 2014 Apple Inc. All rights reserved. -->
-<svg version="1.1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 13 13">
- <path class="stroked" fill="none" stroke="black" stroke-linecap="square" d="M 6.5 1.5 L 6.5 11.5 M 1.5 6.5 L 11.5 6.5"/>
-</svg>
Copied: trunk/Source/WebInspectorUI/UserInterface/Images/Plus13.svg (from rev 189219, trunk/Source/WebInspectorUI/UserInterface/Images/Minus.svg) (0 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Images/Plus13.svg (rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/Plus13.svg 2015-09-01 18:38:09 UTC (rev 189220)
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright © 2015 Apple Inc. All rights reserved. -->
+<svg version="1.1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 13 13">
+ <path class="stroked" fill="none" stroke="black" d="M 6.5 1 V 12 M 1 6.5 H 12"/>
+</svg>
Copied: trunk/Source/WebInspectorUI/UserInterface/Images/Plus15.svg (from rev 189219, trunk/Source/WebInspectorUI/UserInterface/Images/Minus.svg) (0 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Images/Plus15.svg (rev 0)
+++ trunk/Source/WebInspectorUI/UserInterface/Images/Plus15.svg 2015-09-01 18:38:09 UTC (rev 189220)
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright © 2015 Apple Inc. All rights reserved. -->
+<svg version="1.1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 15 15">
+ <path class="stroked" fill="none" stroke="black" d="M 7.5 1 V 14 M 1 7.5 H 14"/>
+</svg>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css 2015-09-01 18:38:09 UTC (rev 189220)
@@ -67,6 +67,7 @@
.sidebar > .panel.details.css-style > .content + .options-container {
display: flex;
+ align-items: center;
position: absolute;
bottom: 0;
width: 100%;
@@ -80,10 +81,12 @@
}
.sidebar > .panel.details.css-style > .content + .options-container > .new-rule {
- width: 17px;
- height: 17px;
- margin: 5px 0 5px 7px;
- content: url(../Images/Plus.svg);
+ width: 15px;
+ min-width: 15px;
+ height: 15px;
+ margin-left: 6px;
+ content: url(../Images/Plus15.svg);
+ opacity: 0.7;
}
.sidebar > .panel.details.css-style > .content + .options-container > .filter-bar {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.css (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.css 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ProbeDetailsSidebarPanel.css 2015-09-01 18:38:09 UTC (rev 189220)
@@ -55,7 +55,7 @@
}
.details-section.probe-set .options > .probe-add {
- content: url(../Images/Plus.svg);
+ content: url(../Images/Plus13.svg);
height: 13px;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.css (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.css 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.css 2015-09-01 18:38:09 UTC (rev 189220)
@@ -42,23 +42,6 @@
border-top: 1px solid hsla(0, 0%, 0%, 0.3);
}
-.sidebar > .panel.details.css-style .rules .new-rule {
- font-size: 12px;
-
- color: black;
-
- padding: 5px 10px;
-
- margin-bottom: 8px;
- margin-top: -5px;
-
- opacity: 0.5;
-}
-
-.sidebar > .panel.details.css-style .rules > *:first-child:matches(.new-rule) {
- margin-top: 8px;
-}
-
.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label {
padding-top: 15px;
}
@@ -76,42 +59,10 @@
padding-top: 0;
}
-.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .new-rule {
- display: none;
-}
-
.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .style-declaration-section:not(.filter-section-non-matching) ~ .label:not(.filter-section-non-matching) {
padding-top: 15px;
}
-.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .style-declaration-section {
- border-top: 1px solid hsla(0, 0%, 0%, 0.3);
-}
-
-.sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .label {
- padding-top: 10px;
- border-top: 1px solid hsla(0, 0%, 0%, 0.3);
-}
-
-.sidebar > .panel.details.css-style .rules .new-rule img {
- content: url(../Images/Plus.svg);
-
- width: 13px;
- height: 13px;
-
- vertical-align: -2px;
-
- margin-right: 6px;
-}
-
-.sidebar > .panel.details.css-style .rules .new-rule:hover {
- opacity: 0.6;
-}
-
-.sidebar > .panel.details.css-style .rules .new-rule:active {
- opacity: 0.7;
-}
-
.sidebar > .panel.details.css-style > .content > .rules:not(.filter-non-matching) > .no-filter-results {
display: none;
}
@@ -138,7 +89,6 @@
}
@media (-webkit-min-device-pixel-ratio: 2) {
- .sidebar > .panel.details.css-style > .content:not(.filter-in-progress) > .rules > .new-rule + .label,
.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules .label.filter-matching-label,
.no-filter-results-message {
border-width: 0.5px !important;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.css (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.css 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScopeChainDetailsSidebarPanel.css 2015-09-01 18:38:09 UTC (rev 189220)
@@ -35,7 +35,7 @@
}
.details-section.watch-expressions .options > .watch-_expression_-add {
- content: url(../Images/Plus.svg);
+ content: url(../Images/Plus13.svg);
}
.details-section.watch-expressions .options > .watch-_expression_-clear {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.css 2015-09-01 18:38:09 UTC (rev 189220)
@@ -206,6 +206,13 @@
opacity: 0.35;
}
+.tab-bar > .item.new-tab-button > .icon {
+ width: 15px;
+ height: 15px;
+ min-width: 15px;
+ min-height: 15px;
+}
+
.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon,
.tab-bar > .item.new-tab-button:not(.disabled):hover > .icon {
opacity: 0.6;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css 2015-09-01 18:38:09 UTC (rev 189220)
@@ -110,7 +110,7 @@
.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-controls > div {
width: 20px;
height: 19px;
- padding: 4px;
+ padding: 3px;
border-right: 1px solid hsl(0, 0%, 83%);
opacity: 0.7;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.js 2015-09-01 18:38:09 UTC (rev 189220)
@@ -43,7 +43,7 @@
controlContainer.classList.add("visual-style-comma-separated-keyword-controls");
this.contentElement.appendChild(controlContainer);
- wrappedSVGDocument("Images/Plus.svg", "visual-style-add-comma-separated-keyword", WebInspector.UIString("Click to add a new item."), function(wrapper) {
+ wrappedSVGDocument("Images/Plus13.svg", "visual-style-add-comma-separated-keyword", WebInspector.UIString("Click to add a new item."), function(wrapper) {
wrapper.addEventListener("click", this._addEmptyCommaSeparatedKeyword.bind(this));
controlContainer.appendChild(wrapper);
}.bind(this));
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js (189219 => 189220)
--- trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js 2015-09-01 18:27:13 UTC (rev 189219)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/VisualStyleSelectorSection.js 2015-09-01 18:38:09 UTC (rev 189220)
@@ -58,7 +58,7 @@
this._selectors._onselect_ = this._selectorChanged.bind(this);
this._focusNextNewInspectorRule = false;
- wrappedSVGDocument("Images/Plus.svg", "visual-style-selector-section-add-rule", WebInspector.UIString("Click to add a new rule."), function(wrapper) {
+ wrappedSVGDocument("Images/Plus13.svg", "visual-style-selector-section-add-rule", WebInspector.UIString("Click to add a new rule."), function(wrapper) {
wrapper.addEventListener("click", this._addNewRule.bind(this));
controlElement.appendChild(wrapper);
}.bind(this));
