Title: [189310] trunk/Source/WebCore
- Revision
- 189310
- Author
- [email protected]
- Date
- 2015-09-03 16:23:44 -0700 (Thu, 03 Sep 2015)
Log Message
New clang warns about boolean checks for |this| pointer in RenderObject debug methods
https://bugs.webkit.org/show_bug.cgi?id=136599
Remove unnecessary null checking.
Reviewed by David Kilzer.
Not testable.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::showRenderObject): Deleted.
(WebCore::RenderObject::showRenderSubTreeAndMark): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (189309 => 189310)
--- trunk/Source/WebCore/ChangeLog 2015-09-03 23:08:39 UTC (rev 189309)
+++ trunk/Source/WebCore/ChangeLog 2015-09-03 23:23:44 UTC (rev 189310)
@@ -1,3 +1,18 @@
+2015-09-03 Zalan Bujtas <[email protected]>
+
+ New clang warns about boolean checks for |this| pointer in RenderObject debug methods
+ https://bugs.webkit.org/show_bug.cgi?id=136599
+
+ Remove unnecessary null checking.
+
+ Reviewed by David Kilzer.
+
+ Not testable.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::showRenderObject): Deleted.
+ (WebCore::RenderObject::showRenderSubTreeAndMark): Deleted.
+
2015-09-03 Adenilson Cavalcanti <[email protected]>
Improve access specifier use in RenderObject
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (189309 => 189310)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2015-09-03 23:08:39 UTC (rev 189309)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2015-09-03 23:23:44 UTC (rev 189310)
@@ -1090,20 +1090,6 @@
void RenderObject::showRenderObject(bool mark, int depth) const
{
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wundefined-bool-conversion"
-#endif
- // As this function is intended to be used when debugging, the |this| pointer may be 0.
- if (!this) {
- fprintf(stderr, "(null)\n");
- return;
- }
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
-
if (isPositioned()) {
if (isRelPositioned())
fputc('R', stderr);
@@ -1210,18 +1196,6 @@
void RenderObject::showRenderSubTreeAndMark(const RenderObject* markedObject, int depth) const
{
-#if COMPILER(CLANG)
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunknown-pragmas"
-#pragma clang diagnostic ignored "-Wundefined-bool-conversion"
-#endif
- // As this function is intended to be used when debugging, the |this| pointer may be nullptr.
- if (!this)
- return;
-#if COMPILER(CLANG)
-#pragma clang diagnostic pop
-#endif
-
showRenderObject(markedObject == this, depth);
if (is<RenderBlockFlow>(*this))
downcast<RenderBlockFlow>(*this).showLineTreeAndMark(nullptr, depth + 1);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
