Title: [189337] trunk/Source/WebKit2
Revision
189337
Author
[email protected]
Date
2015-09-03 20:43:06 -0700 (Thu, 03 Sep 2015)

Log Message

Web Inspector: Closing the Safari window when the Web Inspector is one of the other windows in split screen mode can cause the entire screen to go black
https://bugs.webkit.org/show_bug.cgi?id=148777

Reviewed by Brian Burg.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformHide):
(WebKit::WebInspectorProxy::platformAttach):
Call close instead of orderOut: to make fullscreen and tile modes with Web Inspector work as expected.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (189336 => 189337)


--- trunk/Source/WebKit2/ChangeLog	2015-09-04 03:05:46 UTC (rev 189336)
+++ trunk/Source/WebKit2/ChangeLog	2015-09-04 03:43:06 UTC (rev 189337)
@@ -1,3 +1,16 @@
+2015-09-03  Timothy Hatcher  <[email protected]>
+
+        Web Inspector: Closing the Safari window when the Web Inspector is one of the other windows in split screen mode can cause the entire screen to go black
+        https://bugs.webkit.org/show_bug.cgi?id=148777
+
+        Reviewed by Brian Burg.
+
+        * UIProcess/mac/WebInspectorProxyMac.mm:
+        (WebKit::WebInspectorProxy::platformDidClose):
+        (WebKit::WebInspectorProxy::platformHide):
+        (WebKit::WebInspectorProxy::platformAttach):
+        Call close instead of orderOut: to make fullscreen and tile modes with Web Inspector work as expected.
+
 2015-09-03  Brady Eidson  <[email protected]>
 
         Move SecurityOriginData from WK2 to WebCore.

Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (189336 => 189337)


--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm	2015-09-04 03:05:46 UTC (rev 189336)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm	2015-09-04 03:43:06 UTC (rev 189337)
@@ -549,7 +549,7 @@
 {
     if (m_inspectorWindow) {
         [m_inspectorWindow setDelegate:nil];
-        [m_inspectorWindow orderOut:nil];
+        [m_inspectorWindow close];
         m_inspectorWindow = nil;
     }
 
@@ -572,7 +572,7 @@
 
     if (m_inspectorWindow) {
         [m_inspectorWindow setDelegate:nil];
-        [m_inspectorWindow orderOut:nil];
+        [m_inspectorWindow close];
         m_inspectorWindow = nil;
     }
 }
@@ -790,7 +790,7 @@
 
     if (m_inspectorWindow) {
         [m_inspectorWindow setDelegate:nil];
-        [m_inspectorWindow orderOut:nil];
+        [m_inspectorWindow close];
         m_inspectorWindow = nil;
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to