[webkit-changes] [189366] trunk/Source/WebKit2

Fri, 04 Sep 2015 11:58:53 -0700

Title: [189366] trunk/Source/WebKit2
Revision
189366
Author
[email protected]
Date
2015-09-04 11:58:22 -0700 (Fri, 04 Sep 2015)

Log Message

[iOS] Disable backspace key navigation by default
https://bugs.webkit.org/show_bug.cgi?id=148808

Reviewed by Tim Horton.

* Shared/WebPreferencesDefinitions.h: Defined DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED as
  false on iOS, true elsewhere, and made it the default value of the
  backspaceKeyNavigationEnabled preference key.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (189365 => 189366)


--- trunk/Source/WebKit2/ChangeLog	2015-09-04 18:45:48 UTC (rev 189365)
+++ trunk/Source/WebKit2/ChangeLog	2015-09-04 18:58:22 UTC (rev 189366)
@@ -1,3 +1,14 @@
+2015-09-04  Dan Bernstein  <[email protected]>
+
+        [iOS] Disable backspace key navigation by default
+        https://bugs.webkit.org/show_bug.cgi?id=148808
+
+        Reviewed by Tim Horton.
+
+        * Shared/WebPreferencesDefinitions.h: Defined DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED as
+          false on iOS, true elsewhere, and made it the default value of the
+          backspaceKeyNavigationEnabled preference key.
+
 2015-09-04  Beth Dakin  <[email protected]>
 
         Need to be able to test default behaviors on force click

Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (189365 => 189366)


--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h	2015-09-04 18:45:48 UTC (rev 189365)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h	2015-09-04 18:58:22 UTC (rev 189366)
@@ -49,6 +49,7 @@
 #endif
 
 #if PLATFORM(IOS)
+#define DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED false
 #define DEFAULT_FRAME_FLATTENING_ENABLED true
 #define DEFAULT_SHOULD_PRINT_BACKGROUNDS true
 #define DEFAULT_TEXT_AREAS_ARE_RESIZABLE false
@@ -63,6 +64,7 @@
 #define DEFAULT_MEDIA_CONTROLS_SCALE_WITH_PAGE_ZOOM false
 #define DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED false
 #else
+#define DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED true
 #define DEFAULT_FRAME_FLATTENING_ENABLED false
 #define DEFAULT_SHOULD_PRINT_BACKGROUNDS false
 #define DEFAULT_TEXT_AREAS_ARE_RESIZABLE true
@@ -146,7 +148,7 @@
     macro(MockScrollbarsEnabled, mockScrollbarsEnabled, Bool, bool, false) \
     macro(WebAudioEnabled, webAudioEnabled, Bool, bool, true) \
     macro(SuppressesIncrementalRendering, suppressesIncrementalRendering, Bool, bool, false) \
-    macro(BackspaceKeyNavigationEnabled, backspaceKeyNavigationEnabled, Bool, bool, true) \
+    macro(BackspaceKeyNavigationEnabled, backspaceKeyNavigationEnabled, Bool, bool, DEFAULT_BACKSPACE_KEY_NAVIGATION_ENABLED) \
     macro(CaretBrowsingEnabled, caretBrowsingEnabled, Bool, bool, false) \
     macro(ShouldDisplaySubtitles, shouldDisplaySubtitles, Bool, bool, false) \
     macro(ShouldDisplayCaptions, shouldDisplayCaptions, Bool, bool, false) \

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to