Title: [189370] trunk/LayoutTests
- Revision
- 189370
- Author
- [email protected]
- Date
- 2015-09-04 12:24:55 -0700 (Fri, 04 Sep 2015)
Log Message
swipe-start-hysteresis-failures is flaky
https://bugs.webkit.org/show_bug.cgi?id=148809
Reviewed by Alexey Proskuryakov.
* swipe/swipe-start-hysteresis-failures.html:
* swipe/swipe-start-hysteresis-failures-expected.txt:
Instead of depending on the specific timing of didStartSwipe vs. the events
in this case, just make sure we hit it by the time the test finishes.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (189369 => 189370)
--- trunk/LayoutTests/ChangeLog 2015-09-04 19:14:36 UTC (rev 189369)
+++ trunk/LayoutTests/ChangeLog 2015-09-04 19:24:55 UTC (rev 189370)
@@ -1,3 +1,15 @@
+2015-09-04 Tim Horton <[email protected]>
+
+ swipe-start-hysteresis-failures is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=148809
+
+ Reviewed by Alexey Proskuryakov.
+
+ * swipe/swipe-start-hysteresis-failures.html:
+ * swipe/swipe-start-hysteresis-failures-expected.txt:
+ Instead of depending on the specific timing of didStartSwipe vs. the events
+ in this case, just make sure we hit it by the time the test finishes.
+
2015-09-04 Alexey Proskuryakov <[email protected]>
Skip newly imported IndexedDB test on iOS WebKit1, because IndexedDB only works with WebKit2.
Modified: trunk/LayoutTests/swipe/swipe-start-hysteresis-failures-expected.txt (189369 => 189370)
--- trunk/LayoutTests/swipe/swipe-start-hysteresis-failures-expected.txt 2015-09-04 19:14:36 UTC (rev 189369)
+++ trunk/LayoutTests/swipe/swipe-start-hysteresis-failures-expected.txt 2015-09-04 19:24:55 UTC (rev 189370)
@@ -17,7 +17,6 @@
swipe event (delta 0 0, phase 'maybegin')
scroll event (delta 3 1, phase 'began')
scroll event (delta 0 0, phase 'changed')
-didBeginSwipe
scroll event (delta 0 0, phase 'ended')
swipe event (delta 0 0, phase 'ended')
Modified: trunk/LayoutTests/swipe/swipe-start-hysteresis-failures.html (189369 => 189370)
--- trunk/LayoutTests/swipe/swipe-start-hysteresis-failures.html 2015-09-04 19:14:36 UTC (rev 189369)
+++ trunk/LayoutTests/swipe/swipe-start-hysteresis-failures.html 2015-09-04 19:24:55 UTC (rev 189370)
@@ -59,14 +59,15 @@
{
// Swap in a different callback that makes sure we *do* reach didBeginSwipe.
testRunner.clearTestRunnerCallbacks();
+ var sawDidBeginSwipe = false;
testRunner.installDidBeginSwipeCallback(function () {
- log("didBeginSwipe");
-
+ sawDidBeginSwipe = true;
// Need a swipe-end event to clean up.
eventQueue.enqueueSwipeEvent(0, 0, 'ended');
});
testRunner.installDidRemoveSwipeSnapshotCallback(function () {
+ shouldBe(true, sawDidBeginSwipe, "The last gesture should start a swipe, because it is sufficient magnitude and in the correct direction.")
testComplete();
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
