Title: [189590] trunk/Source/WebInspectorUI
- Revision
- 189590
- Author
- [email protected]
- Date
- 2015-09-10 14:13:24 -0700 (Thu, 10 Sep 2015)
Log Message
Web Inspector: Prefer calling ContentViewContainer.updateLayout directly
https://bugs.webkit.org/show_bug.cgi?id=149041
Reviewed by Timothy Hatcher.
Cleaned up two places where a parent view duplicated logic encapsulated by ContentViewContainer.
* UserInterface/Views/ClusterContentView.js:
(WebInspector.ClusterContentView.prototype.updateLayout):
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.updateLayout):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (189589 => 189590)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-09-10 21:06:01 UTC (rev 189589)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-09-10 21:13:24 UTC (rev 189590)
@@ -1,3 +1,17 @@
+2015-09-10 Matt Baker <[email protected]>
+
+ Web Inspector: Prefer calling ContentViewContainer.updateLayout directly
+ https://bugs.webkit.org/show_bug.cgi?id=149041
+
+ Reviewed by Timothy Hatcher.
+
+ Cleaned up two places where a parent view duplicated logic encapsulated by ContentViewContainer.
+
+ * UserInterface/Views/ClusterContentView.js:
+ (WebInspector.ClusterContentView.prototype.updateLayout):
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WebInspector.TimelineRecordingContentView.prototype.updateLayout):
+
2015-09-08 Matt Baker <[email protected]>
Web Inspector: REGRESSION (r189189): Missing breakpoint context menu for debugger sidebar tree elements
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js (189589 => 189590)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js 2015-09-10 21:06:01 UTC (rev 189589)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ClusterContentView.js 2015-09-10 21:13:24 UTC (rev 189590)
@@ -62,9 +62,7 @@
updateLayout()
{
- var currentContentView = this._contentViewContainer.currentContentView;
- if (currentContentView)
- currentContentView.updateLayout();
+ this._contentViewContainer.updateLayout();
}
shown()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (189589 => 189590)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2015-09-10 21:06:01 UTC (rev 189589)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2015-09-10 21:13:24 UTC (rev 189590)
@@ -213,10 +213,7 @@
updateLayout()
{
this._currentTimelineOverview.updateLayoutForResize();
-
- var currentContentView = this._contentViewContainer.currentContentView;
- if (currentContentView)
- currentContentView.updateLayout();
+ this._contentViewContainer.updateLayout();
}
saveToCookie(cookie)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
