Title: [189593] trunk/Source/WebInspectorUI
- Revision
- 189593
- Author
- [email protected]
- Date
- 2015-09-10 14:54:31 -0700 (Thu, 10 Sep 2015)
Log Message
Web Inspector: Styles sidebar says Media: all when it should say Media: screen
https://bugs.webkit.org/show_bug.cgi?id=148436
Patch by Devin Rousso <[email protected]> on 2015-09-10
Reviewed by Timothy Hatcher.
Removed filter that prevented "Media: screen" from being displayed.
* UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
(WebInspector.RulesStyleDetailsPanel.prototype.refresh.filteredMediaList): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (189592 => 189593)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-09-10 21:28:27 UTC (rev 189592)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-09-10 21:54:31 UTC (rev 189593)
@@ -1,3 +1,16 @@
+2015-09-10 Devin Rousso <[email protected]>
+
+ Web Inspector: Styles sidebar says Media: all when it should say Media: screen
+ https://bugs.webkit.org/show_bug.cgi?id=148436
+
+ Reviewed by Timothy Hatcher.
+
+ Removed filter that prevented "Media: screen" from being displayed.
+
+ * UserInterface/Views/RulesStyleDetailsPanel.js:
+ (WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
+ (WebInspector.RulesStyleDetailsPanel.prototype.refresh.filteredMediaList): Deleted.
+
2015-09-10 Matt Baker <[email protected]>
Web Inspector: Prefer calling ContentViewContainer.updateLayout directly
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js (189592 => 189593)
--- trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js 2015-09-10 21:28:27 UTC (rev 189592)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js 2015-09-10 21:54:31 UTC (rev 189593)
@@ -116,17 +116,6 @@
return true;
}
- function filteredMediaList(mediaList)
- {
- if (!mediaList)
- return [];
-
- // Exclude the basic "screen" query since it's very common and just clutters things.
- return mediaList.filter(function(media) {
- return media.text !== "screen";
- });
- }
-
function uniqueOrderedStyles(orderedStyles)
{
var uniqueStyles = [];
@@ -201,7 +190,7 @@
}
// Only include the media list if it is different from the previous media list shown.
- var currentMediaList = filteredMediaList(style.ownerRule && style.ownerRule.mediaList);
+ var currentMediaList = (style.ownerRule && style.ownerRule.mediaList) || [];
if (!mediaListsEqual(previousMediaList, currentMediaList)) {
previousMediaList = currentMediaList;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
