Title: [189595] trunk
- Revision
- 189595
- Author
- [email protected]
- Date
- 2015-09-10 15:59:08 -0700 (Thu, 10 Sep 2015)
Log Message
Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
https://bugs.webkit.org/show_bug.cgi?id=142929
Reviewed by Brent Fulgham.
Tools:
Silence the logging. We'll track fixing the root cause in Radar.
* Scripts/webkitpy/port/mac.py:
(MacPort.stderr_patterns_to_strip): Added a FIXME.
* Scripts/webkitpy/port/win.py:
(WinPort.logging_patterns_to_strip): Added.
LayoutTests:
* platform/win/TestExpectations: Unskip some newly added tests that are affected.
We still skip the whole media directory - updating the results and unskipping those
tests would be a separate project.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (189594 => 189595)
--- trunk/LayoutTests/ChangeLog 2015-09-10 22:15:46 UTC (rev 189594)
+++ trunk/LayoutTests/ChangeLog 2015-09-10 22:59:08 UTC (rev 189595)
@@ -1,3 +1,14 @@
+2015-09-10 Alexey Proskuryakov <[email protected]>
+
+ Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
+ https://bugs.webkit.org/show_bug.cgi?id=142929
+
+ Reviewed by Brent Fulgham.
+
+ * platform/win/TestExpectations: Unskip some newly added tests that are affected.
+ We still skip the whole media directory - updating the results and unskipping those
+ tests would be a separate project.
+
2015-09-10 David Hyatt <[email protected]>
[New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks
Modified: trunk/LayoutTests/platform/win/TestExpectations (189594 => 189595)
--- trunk/LayoutTests/platform/win/TestExpectations 2015-09-10 22:15:46 UTC (rev 189594)
+++ trunk/LayoutTests/platform/win/TestExpectations 2015-09-10 22:59:08 UTC (rev 189595)
@@ -726,8 +726,6 @@
# Sensitive to load timing or PHP behavior
webkit.org/b/44873 http/tests/css/css-image-loading.html [ Skip ]
-webkit.org/b/149007 http/tests/css/link-css-disabled-value-with-slow-loading-sheet.html [ Pass Failure ]
-http/tests/css/link-css-disabled-value-with-slow-loading-sheet-in-error.html [ Pass Failure ] # Flaky
# Assertion failure in replaySavedEvents http://webkit.org/b/21796
webkit.org/b/21796 fast/events/dragging-mouse-moves.html [ Skip ]
@@ -752,15 +750,13 @@
################################################################################
# Deactivate all media tests on Apple Windows due to <rdar://problem/18681688> generating
# spam logging output that causes tests to fail. Will re-enable once this is fixed.
+# FIXME: We now filter out the logging, so many of the tests can likely be re-enabled.
media [ Skip ]
fast/media [ Skip ]
http/tests/media [ Skip ]
fast/layers/video-layer.html [ Skip ] # Skip until video control changes are done.
-# "AQMEIOManager::FindIOUnit: error -1" errors in tests output.
-webkit.org/b/148903 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/ [ Skip ]
-
# Assertion failures
webkit.org/b/48910 [ Debug ] http/tests/media/pdf-served-as-pdf.html [ Skip ] # Crashing
webkit.org/b/48910 http/tests/media/video-cancel-load.html [ Skip ] # Crashing
Modified: trunk/Tools/ChangeLog (189594 => 189595)
--- trunk/Tools/ChangeLog 2015-09-10 22:15:46 UTC (rev 189594)
+++ trunk/Tools/ChangeLog 2015-09-10 22:59:08 UTC (rev 189595)
@@ -1,3 +1,18 @@
+2015-09-10 Alexey Proskuryakov <[email protected]>
+
+ Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
+ https://bugs.webkit.org/show_bug.cgi?id=142929
+
+ Reviewed by Brent Fulgham.
+
+ Silence the logging. We'll track fixing the root cause in Radar.
+
+ * Scripts/webkitpy/port/mac.py:
+ (MacPort.stderr_patterns_to_strip): Added a FIXME.
+
+ * Scripts/webkitpy/port/win.py:
+ (WinPort.logging_patterns_to_strip): Added.
+
2015-09-09 Andy Estes <[email protected]>
[iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
Modified: trunk/Tools/Scripts/webkitpy/port/mac.py (189594 => 189595)
--- trunk/Tools/Scripts/webkitpy/port/mac.py 2015-09-10 22:15:46 UTC (rev 189594)
+++ trunk/Tools/Scripts/webkitpy/port/mac.py 2015-09-10 22:59:08 UTC (rev 189595)
@@ -312,6 +312,7 @@
def stderr_patterns_to_strip(self):
worthless_patterns = []
+ # FIXME: We still get CoreMedia stderr logging that doesn't match the below lines. 'defaults write com.apple.coremedia fig_notes 0' may work better for silencing them all, however running tests shouldn't change user's defaults.
worthless_patterns.append((re.compile('.*(Fig|fig|itemasync|vt|mv_|PullParamSetSPS|ccrp_|client).* signalled err=.*\n'), ''))
worthless_patterns.append((re.compile('.*<<<< FigFilePlayer >>>>.*\n'), ''))
worthless_patterns.append((re.compile('.*<<<< FigFile >>>>.*\n'), ''))
Modified: trunk/Tools/Scripts/webkitpy/port/win.py (189594 => 189595)
--- trunk/Tools/Scripts/webkitpy/port/win.py 2015-09-10 22:15:46 UTC (rev 189594)
+++ trunk/Tools/Scripts/webkitpy/port/win.py 2015-09-10 22:59:08 UTC (rev 189595)
@@ -328,3 +328,7 @@
pass
return system_pid
+
+ def logging_patterns_to_strip(self):
+ # rdar://problem/18681688
+ return [(re.compile('AQMEIOManager::FindIOUnit: error \-1\n'), '')]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
