Title: [189598] trunk
Revision
189598
Author
[email protected]
Date
2015-09-10 17:55:14 -0700 (Thu, 10 Sep 2015)

Log Message

AX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
https://bugs.webkit.org/show_bug.cgi?id=148891

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Asychronous focus setting DOES work on Yosemite, just not Mavericks.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):

LayoutTests:

Mark accessibility focus tests as passing on Yosemite.

* platform/mac/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (189597 => 189598)


--- trunk/LayoutTests/ChangeLog	2015-09-10 23:19:45 UTC (rev 189597)
+++ trunk/LayoutTests/ChangeLog	2015-09-11 00:55:14 UTC (rev 189598)
@@ -1,3 +1,14 @@
+2015-09-10  Chris Fleizach  <[email protected]>
+
+        AX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
+        https://bugs.webkit.org/show_bug.cgi?id=148891
+
+        Reviewed by Alexey Proskuryakov.
+
+        Mark accessibility focus tests as passing on Yosemite.
+
+        * platform/mac/TestExpectations:
+
 2015-09-10  Alexey Proskuryakov  <[email protected]>
 
         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1

Modified: trunk/LayoutTests/platform/mac/TestExpectations (189597 => 189598)


--- trunk/LayoutTests/platform/mac/TestExpectations	2015-09-10 23:19:45 UTC (rev 189597)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2015-09-11 00:55:14 UTC (rev 189598)
@@ -1194,8 +1194,8 @@
 webkit.org/b/17022 [ MountainLion Mavericks ] fast/images/animated-png.html [ Skip ]
 
 # Pre-Capitan does not support asynchronous attribute setting.
-[ Mavericks Yosemite ] accessibility/mac/setting-attributes-is-asynchronous.html [ Skip ]
-[ Mavericks Yosemite ] accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html [ Skip ]
+[ Mavericks ] accessibility/mac/setting-attributes-is-asynchronous.html [ Skip ]
+[ Mavericks ] accessibility/mac/focus-setting-selection-syncronizing-not-clearing.html [ Skip ]
 
 # OS X 10.10.3+ has the necessary glyphs.
 webkit.org/b/142548 [ Yosemite+ ] editing/selection/extend-by-character-007.html [ Pass ]

Modified: trunk/Source/WebCore/ChangeLog (189597 => 189598)


--- trunk/Source/WebCore/ChangeLog	2015-09-10 23:19:45 UTC (rev 189597)
+++ trunk/Source/WebCore/ChangeLog	2015-09-11 00:55:14 UTC (rev 189598)
@@ -1,3 +1,16 @@
+2015-09-10  Chris Fleizach  <[email protected]>
+
+        AX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
+        https://bugs.webkit.org/show_bug.cgi?id=148891
+
+        Reviewed by Alexey Proskuryakov.
+
+        Asychronous focus setting DOES work on Yosemite, just not Mavericks.
+
+        * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+        (-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
+        (-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):
+
 2015-09-10  David Hyatt  <[email protected]>
 
         [New Block-Inside-Inline Model] Self-collapsing block check needs to account for anonymous inline blocks

Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (189597 => 189598)


--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2015-09-10 23:19:45 UTC (rev 189597)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2015-09-11 00:55:14 UTC (rev 189598)
@@ -3393,7 +3393,7 @@
 
 - (void)accessibilitySetValue:(id)value forAttribute:(NSString*)attributeName
 {
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
     // In case anything we do by changing values causes an alert or other modal
     // behaviors, we need to return now, so that VoiceOver doesn't hang indefinitely.
     dispatch_async(dispatch_get_main_queue(), ^{
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to