Title: [189782] releases/WebKitGTK/webkit-2.10
- Revision
- 189782
- Author
- carlo...@webkit.org
- Date
- 2015-09-15 00:17:25 -0700 (Tue, 15 Sep 2015)
Log Message
Merge r189502 - document.importNode(node, deep): deep's default value should be false
https://bugs.webkit.org/show_bug.cgi?id=148959
<rdar://problem/22558915>
Reviewed by Alexey Proskuryakov.
LayoutTests/imported/w3c:
* web-platform-tests/dom/nodes/Document-importNode-expected.txt:
Rebaseline now that an additional check is passing.
Source/WebCore:
Switch deep parameter's default value for document.importNode() to
false, as per the latest DOM specification:
- https://dom.spec.whatwg.org/#interface-document
- https://dom.spec.whatwg.org/#dom-document-importnode
Firefox and Chrome follow the specification. However, WebKit was using
"true" for deep's default value.
No new tests, already covered by:
imported/w3c/web-platform-tests/dom/nodes/Document-importNode.html
* dom/Document.h:
(WebCore::Document::importNode):
LayoutTests:
* fast/dom/document-importNode-arguments.html:
Explicitly pass deep parameter as the test wants a deep clone.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog (189781 => 189782)
--- releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog 2015-09-15 06:59:24 UTC (rev 189781)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/ChangeLog 2015-09-15 07:17:25 UTC (rev 189782)
@@ -1,3 +1,14 @@
+2015-09-08 Chris Dumez <cdu...@apple.com>
+
+ document.importNode(node, deep): deep's default value should be false
+ https://bugs.webkit.org/show_bug.cgi?id=148959
+ <rdar://problem/22558915>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * fast/dom/document-importNode-arguments.html:
+ Explicitly pass deep parameter as the test wants a deep clone.
+
2015-09-07 Daniel Bates <daba...@apple.com>
ASSERT_WITH_SECURITY_IMPLICATION in WebCore::DocumentOrderedMap::get(); update form
Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/fast/dom/document-importNode-arguments.html (189781 => 189782)
--- releases/WebKitGTK/webkit-2.10/LayoutTests/fast/dom/document-importNode-arguments.html 2015-09-15 06:59:24 UTC (rev 189781)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/fast/dom/document-importNode-arguments.html 2015-09-15 07:17:25 UTC (rev 189782)
@@ -14,7 +14,7 @@
var d = document.createElement("div");
d.innerHTML = "<span>hello </span><span>world</span>";
-imported = document.importNode(d);
+imported = document.importNode(d, true);
shouldBe('imported.childNodes.length','2');
shouldBeTrue("imported.textContent == 'hello world'");
Modified: releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog (189781 => 189782)
--- releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog 2015-09-15 06:59:24 UTC (rev 189781)
+++ releases/WebKitGTK/webkit-2.10/LayoutTests/imported/w3c/ChangeLog 2015-09-15 07:17:25 UTC (rev 189782)
@@ -1,3 +1,14 @@
+2015-09-08 Chris Dumez <cdu...@apple.com>
+
+ document.importNode(node, deep): deep's default value should be false
+ https://bugs.webkit.org/show_bug.cgi?id=148959
+ <rdar://problem/22558915>
+
+ Reviewed by Alexey Proskuryakov.
+
+ * web-platform-tests/dom/nodes/Document-importNode-expected.txt:
+ Rebaseline now that an additional check is passing.
+
2015-04-13 Alexey Proskuryakov <a...@apple.com>
imported/w3c/canvas/2d.text.measure.width.empty.html is flaky
Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog (189781 => 189782)
--- releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2015-09-15 06:59:24 UTC (rev 189781)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/ChangeLog 2015-09-15 07:17:25 UTC (rev 189782)
@@ -1,3 +1,25 @@
+2015-09-08 Chris Dumez <cdu...@apple.com>
+
+ document.importNode(node, deep): deep's default value should be false
+ https://bugs.webkit.org/show_bug.cgi?id=148959
+ <rdar://problem/22558915>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Switch deep parameter's default value for document.importNode() to
+ false, as per the latest DOM specification:
+ - https://dom.spec.whatwg.org/#interface-document
+ - https://dom.spec.whatwg.org/#dom-document-importnode
+
+ Firefox and Chrome follow the specification. However, WebKit was using
+ "true" for deep's default value.
+
+ No new tests, already covered by:
+ imported/w3c/web-platform-tests/dom/nodes/Document-importNode.html
+
+ * dom/Document.h:
+ (WebCore::Document::importNode):
+
2015-09-07 Daniel Bates <daba...@apple.com>
ASSERT_WITH_SECURITY_IMPLICATION in WebCore::DocumentOrderedMap::get(); update form
Modified: releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.h (189781 => 189782)
--- releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.h 2015-09-15 06:59:24 UTC (rev 189781)
+++ releases/WebKitGTK/webkit-2.10/Source/WebCore/dom/Document.h 2015-09-15 07:17:25 UTC (rev 189782)
@@ -376,7 +376,7 @@
RefPtr<Attr> createAttribute(const String& name, ExceptionCode&);
RefPtr<Attr> createAttributeNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&, bool shouldIgnoreNamespaceChecks = false);
RefPtr<EntityReference> createEntityReference(const String& name, ExceptionCode&);
- RefPtr<Node> importNode(Node* importedNode, ExceptionCode& ec) { return importNode(importedNode, true, ec); }
+ RefPtr<Node> importNode(Node* importedNode, ExceptionCode& ec) { return importNode(importedNode, false, ec); }
RefPtr<Node> importNode(Node* importedNode, bool deep, ExceptionCode&);
WEBCORE_EXPORT RefPtr<Element> createElementNS(const String& namespaceURI, const String& qualifiedName, ExceptionCode&);
WEBCORE_EXPORT Ref<Element> createElement(const QualifiedName&, bool createdByParser);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
