Title: [190377] trunk/Source/WebInspectorUI
- Revision
- 190377
- Author
- commit-qu...@webkit.org
- Date
- 2015-09-30 17:26:12 -0700 (Wed, 30 Sep 2015)
Log Message
Web Inspector: Thousands of timers fire after switching to _javascript_ and Events timeline
https://bugs.webkit.org/show_bug.cgi?id=149682
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-09-30
Reviewed by Timothy Hatcher.
Setting the status element of a GeneralTreeElement was triggering a
TreeOutline.onchange event. For TreeOutlines with lots of tree elements
(_javascript_ & Events with profile nodes) this could result in thousands
of onchange events that causes lots of unnecessary work and blocks
future timers (like scroll synchronization) from firing.
This change eliminates TreeOutline change events for tree element
changes that are not interesting.
* UserInterface/Views/GeneralTreeElement.js:
(WebInspector.GeneralTreeElement.prototype.set status): Deleted.
* UserInterface/Views/TreeOutline.js:
(WebInspector.TreeElement.prototype.set tooltip): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (190376 => 190377)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-10-01 00:08:18 UTC (rev 190376)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-10-01 00:26:12 UTC (rev 190377)
@@ -1,5 +1,26 @@
2015-09-30 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Thousands of timers fire after switching to _javascript_ and Events timeline
+ https://bugs.webkit.org/show_bug.cgi?id=149682
+
+ Reviewed by Timothy Hatcher.
+
+ Setting the status element of a GeneralTreeElement was triggering a
+ TreeOutline.onchange event. For TreeOutlines with lots of tree elements
+ (_javascript_ & Events with profile nodes) this could result in thousands
+ of onchange events that causes lots of unnecessary work and blocks
+ future timers (like scroll synchronization) from firing.
+
+ This change eliminates TreeOutline change events for tree element
+ changes that are not interesting.
+
+ * UserInterface/Views/GeneralTreeElement.js:
+ (WebInspector.GeneralTreeElement.prototype.set status): Deleted.
+ * UserInterface/Views/TreeOutline.js:
+ (WebInspector.TreeElement.prototype.set tooltip): Deleted.
+
+2015-09-30 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Reduce `delete` in TreeElements and DataGridNodes
https://bugs.webkit.org/show_bug.cgi?id=149680
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js (190376 => 190377)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2015-10-01 00:08:18 UTC (rev 190376)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2015-10-01 00:26:12 UTC (rev 190377)
@@ -188,7 +188,6 @@
this._status = x || "";
this._updateStatusElement();
- this.didChange();
}
get filterableData()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (190376 => 190377)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2015-10-01 00:08:18 UTC (rev 190376)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2015-10-01 00:26:12 UTC (rev 190377)
@@ -620,7 +620,6 @@
this._tooltip = x;
if (this._listItemNode)
this._listItemNode.title = x ? x : "";
- this.didChange();
}
get hasChildren()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
