Title: [190610] trunk/Source/WebCore
- Revision
- 190610
- Author
- calva...@igalia.com
- Date
- 2015-10-06 01:02:00 -0700 (Tue, 06 Oct 2015)
Log Message
JSBuiltinConstructor must always add builtin header
https://bugs.webkit.org/show_bug.cgi?id=149759
Reviewed by Darin Adler.
Covered by TestJSBuiltinConstructor.idl.
* bindings/scripts/CodeGeneratorJS.pm:
(AddIncludesForJSBuiltinMethods): Forces adding the builtin header when the JSBuiltinConstructor is present.
* bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp: Expectation.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (190609 => 190610)
--- trunk/Source/WebCore/ChangeLog 2015-10-06 06:54:48 UTC (rev 190609)
+++ trunk/Source/WebCore/ChangeLog 2015-10-06 08:02:00 UTC (rev 190610)
@@ -1,3 +1,16 @@
+2015-10-06 Xabier Rodriguez Calvar <calva...@igalia.com>
+
+ JSBuiltinConstructor must always add builtin header
+ https://bugs.webkit.org/show_bug.cgi?id=149759
+
+ Reviewed by Darin Adler.
+
+ Covered by TestJSBuiltinConstructor.idl.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (AddIncludesForJSBuiltinMethods): Forces adding the builtin header when the JSBuiltinConstructor is present.
+ * bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp: Expectation.
+
2015-10-05 Youenn Fablet <youenn.fab...@crf.canon.fr>
Migrate streams API to JS Builtins
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (190609 => 190610)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-10-06 06:54:48 UTC (rev 190609)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-10-06 08:02:00 UTC (rev 190610)
@@ -5115,6 +5115,11 @@
{
my $interface = shift;
+ if ($interface->extendedAttributes->{"JSBuiltinConstructor"}) {
+ AddToImplIncludes($interface->name . "Builtins.h");
+ return 1;
+ }
+
foreach my $function (@{$interface->functions}) {
next unless ($function->signature->extendedAttributes->{"JSBuiltin"});
my $scopeName = $function->signature->extendedAttributes->{"ImplementedBy"};
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp (190609 => 190610)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp 2015-10-06 06:54:48 UTC (rev 190609)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp 2015-10-06 08:02:00 UTC (rev 190610)
@@ -22,6 +22,7 @@
#include "JSTestJSBuiltinConstructor.h"
#include "JSDOMBinding.h"
+#include "TestJSBuiltinConstructorBuiltins.h"
#include <wtf/GetPtr.h>
using namespace JSC;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
