Title: [190681] trunk/Source/_javascript_Core
- Revision
- 190681
- Author
- [email protected]
- Date
- 2015-10-07 13:25:29 -0700 (Wed, 07 Oct 2015)
Log Message
Get rid of JIT::compilePutDirectOffset
https://bugs.webkit.org/show_bug.cgi?id=149884
Reviewed by Andreas Kling.
I'm finding more dead code.
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_put_by_id):
(JSC::JIT::emitVarInjectionCheck):
(JSC::JIT::compilePutDirectOffset): Deleted.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (190680 => 190681)
--- trunk/Source/_javascript_Core/ChangeLog 2015-10-07 19:59:32 UTC (rev 190680)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-10-07 20:25:29 UTC (rev 190681)
@@ -1,3 +1,18 @@
+2015-10-07 Filip Pizlo <[email protected]>
+
+ Get rid of JIT::compilePutDirectOffset
+ https://bugs.webkit.org/show_bug.cgi?id=149884
+
+ Reviewed by Andreas Kling.
+
+ I'm finding more dead code.
+
+ * jit/JIT.h:
+ * jit/JITPropertyAccess.cpp:
+ (JSC::JIT::emitSlow_op_put_by_id):
+ (JSC::JIT::emitVarInjectionCheck):
+ (JSC::JIT::compilePutDirectOffset): Deleted.
+
2015-10-07 Joseph Pecoraro <[email protected]>
Heap::isWriteBarrierEnabled is unused
Modified: trunk/Source/_javascript_Core/jit/JIT.h (190680 => 190681)
--- trunk/Source/_javascript_Core/jit/JIT.h 2015-10-07 19:59:32 UTC (rev 190680)
+++ trunk/Source/_javascript_Core/jit/JIT.h 2015-10-07 20:25:29 UTC (rev 190681)
@@ -467,10 +467,6 @@
void compileBinaryArithOpSlowCase(Instruction*, OpcodeID, Vector<SlowCaseEntry>::iterator&, int dst, int src1, int src2, OperandTypes, bool op1HasImmediateIntFastCase, bool op2HasImmediateIntFastCase);
void compileGetByIdHotPath(int baseVReg, const Identifier*);
- void compileGetDirectOffset(RegisterID base, RegisterID result, PropertyOffset cachedOffset);
- void compileGetDirectOffset(JSObject* base, RegisterID result, PropertyOffset cachedOffset);
- void compileGetDirectOffset(RegisterID base, RegisterID result, RegisterID offset, RegisterID scratch, FinalObjectMode = MayBeFinal);
- void compilePutDirectOffset(RegisterID base, RegisterID value, PropertyOffset cachedOffset);
#endif // USE(JSVALUE32_64)
Modified: trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp (190680 => 190681)
--- trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp 2015-10-07 19:59:32 UTC (rev 190680)
+++ trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp 2015-10-07 20:25:29 UTC (rev 190681)
@@ -623,19 +623,6 @@
gen.reportSlowPathCall(coldPathBegin, call);
}
-// Compile a store into an object's property storage. May overwrite the
-// value in objectReg.
-void JIT::compilePutDirectOffset(RegisterID base, RegisterID value, PropertyOffset cachedOffset)
-{
- if (isInlineOffset(cachedOffset)) {
- store64(value, Address(base, JSObject::offsetOfInlineStorage() + sizeof(JSValue) * offsetInInlineStorage(cachedOffset)));
- return;
- }
-
- loadPtr(Address(base, JSObject::butterflyOffset()), base);
- store64(value, Address(base, sizeof(JSValue) * offsetInButterfly(cachedOffset)));
-}
-
void JIT::emitVarInjectionCheck(bool needsVarInjectionChecks)
{
if (!needsVarInjectionChecks)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
