Title: [190721] trunk/Source/WebCore
- Revision
- 190721
- Author
- [email protected]
- Date
- 2015-10-08 06:28:54 -0700 (Thu, 08 Oct 2015)
Log Message
[css-grid] Percentages of indefinite sizes to be resolved as auto
https://bugs.webkit.org/show_bug.cgi?id=149810
Reviewed by Darin Adler.
Specs mention that percentages in grid track sizes must be
resolved as 'auto' if the grid container has an indefinite
size in the corresponding axis.
The 'auto' keyword used to be resolved as
minmax(min-content,max-content) but since r189911 it's
resolved as minmax(auto,auto). Updated the implementation so
we properly resolve those percentages.
No new tests as the behavior does not change at all. That's
because 'auto' as min-track sizing function is the same as
min-content (unless we have a specified value for
min-{width|height}, but those cases were already handled in the
code), and as a max sizing function is works as max-content.
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::gridTrackSize):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (190720 => 190721)
--- trunk/Source/WebCore/ChangeLog 2015-10-08 12:26:55 UTC (rev 190720)
+++ trunk/Source/WebCore/ChangeLog 2015-10-08 13:28:54 UTC (rev 190721)
@@ -1,3 +1,28 @@
+2015-10-08 Sergio Villar Senin <[email protected]>
+
+ [css-grid] Percentages of indefinite sizes to be resolved as auto
+ https://bugs.webkit.org/show_bug.cgi?id=149810
+
+ Reviewed by Darin Adler.
+
+ Specs mention that percentages in grid track sizes must be
+ resolved as 'auto' if the grid container has an indefinite
+ size in the corresponding axis.
+
+ The 'auto' keyword used to be resolved as
+ minmax(min-content,max-content) but since r189911 it's
+ resolved as minmax(auto,auto). Updated the implementation so
+ we properly resolve those percentages.
+
+ No new tests as the behavior does not change at all. That's
+ because 'auto' as min-track sizing function is the same as
+ min-content (unless we have a specified value for
+ min-{width|height}, but those cases were already handled in the
+ code), and as a max sizing function is works as max-content.
+
+ * rendering/RenderGrid.cpp:
+ (WebCore::RenderGrid::gridTrackSize):
+
2015-10-08 Xabier Rodriguez Calvar <[email protected]> and Youenn Fablet <[email protected]>
Automate WebCore JS builtins generation and build system
Modified: trunk/Source/WebCore/rendering/RenderGrid.cpp (190720 => 190721)
--- trunk/Source/WebCore/rendering/RenderGrid.cpp 2015-10-08 12:26:55 UTC (rev 190720)
+++ trunk/Source/WebCore/rendering/RenderGrid.cpp 2015-10-08 13:28:54 UTC (rev 190721)
@@ -34,7 +34,6 @@
#include "LayoutRepainter.h"
#include "RenderLayer.h"
#include "RenderView.h"
-#include <wtf/NeverDestroyed.h>
namespace WebCore {
@@ -577,9 +576,9 @@
if (minTrackBreadth.isPercentage() || maxTrackBreadth.isPercentage()) {
if (!hasDefiniteLogicalSize(direction)) {
if (minTrackBreadth.isPercentage())
- minTrackBreadth = Length(MinContent);
+ minTrackBreadth = Length(Auto);
if (maxTrackBreadth.isPercentage())
- maxTrackBreadth = Length(MaxContent);
+ maxTrackBreadth = Length(Auto);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
