Title: [190728] trunk
- Revision
- 190728
- Author
- [email protected]
- Date
- 2015-10-08 09:26:40 -0700 (Thu, 08 Oct 2015)
Log Message
CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
https://bugs.webkit.org/show_bug.cgi?id=149921
rdar://problem/22731359
Reviewed by Andreas Kling.
Source/WebCore:
Test: svg/css/use-window-inactive-crash.html
* css/SelectorCheckerTestFunctions.h:
(WebCore::isWindowInactive):
Null check page.
LayoutTests:
The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
it for coverage.
* svg/css/use-window-inactive-crash-expected.html: Added.
* svg/css/use-window-inactive-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (190727 => 190728)
--- trunk/LayoutTests/ChangeLog 2015-10-08 15:33:36 UTC (rev 190727)
+++ trunk/LayoutTests/ChangeLog 2015-10-08 16:26:40 UTC (rev 190728)
@@ -1,3 +1,17 @@
+2015-10-08 Antti Koivisto <[email protected]>
+
+ CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
+ https://bugs.webkit.org/show_bug.cgi?id=149921
+ rdar://problem/22731359
+
+ Reviewed by Andreas Kling.
+
+ The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
+ it for coverage.
+
+ * svg/css/use-window-inactive-crash-expected.html: Added.
+ * svg/css/use-window-inactive-crash.html: Added.
+
2015-10-08 Carlos Garcia Campos <[email protected]>
[GTK] Stop using a nested main loop for popup menus
Added: trunk/LayoutTests/svg/css/use-window-inactive-crash-expected.html (0 => 190728)
--- trunk/LayoutTests/svg/css/use-window-inactive-crash-expected.html (rev 0)
+++ trunk/LayoutTests/svg/css/use-window-inactive-crash-expected.html 2015-10-08 16:26:40 UTC (rev 190728)
@@ -0,0 +1,2 @@
+<svg><use xlink:href=""
+if you see this, then your browser didn't crash.
Added: trunk/LayoutTests/svg/css/use-window-inactive-crash.html (0 => 190728)
--- trunk/LayoutTests/svg/css/use-window-inactive-crash.html (rev 0)
+++ trunk/LayoutTests/svg/css/use-window-inactive-crash.html 2015-10-08 16:26:40 UTC (rev 190728)
@@ -0,0 +1,3 @@
+<style>::-webkit-scrollbar-thumb:window-inactive { background: rgba(0, 0, 0, 0); }</style>
+<svg><use xlink:href=""
+if you see this, then your browser didn't crash.
Modified: trunk/Source/WebCore/ChangeLog (190727 => 190728)
--- trunk/Source/WebCore/ChangeLog 2015-10-08 15:33:36 UTC (rev 190727)
+++ trunk/Source/WebCore/ChangeLog 2015-10-08 16:26:40 UTC (rev 190728)
@@ -1,3 +1,18 @@
+2015-10-08 Antti Koivisto <[email protected]>
+
+ CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
+ https://bugs.webkit.org/show_bug.cgi?id=149921
+ rdar://problem/22731359
+
+ Reviewed by Andreas Kling.
+
+ Test: svg/css/use-window-inactive-crash.html
+
+ * css/SelectorCheckerTestFunctions.h:
+ (WebCore::isWindowInactive):
+
+ Null check page.
+
2015-10-08 Michael Catanzaro <[email protected]>
Format string issues in LegacyRequest.cpp
Modified: trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h (190727 => 190728)
--- trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h 2015-10-08 15:33:36 UTC (rev 190727)
+++ trunk/Source/WebCore/css/SelectorCheckerTestFunctions.h 2015-10-08 16:26:40 UTC (rev 190728)
@@ -117,7 +117,10 @@
ALWAYS_INLINE bool isWindowInactive(const Element* element)
{
- return !element->document().page()->focusController().isActive();
+ auto* page = element->document().page();
+ if (!page)
+ return false;
+ return !page->focusController().isActive();
}
ALWAYS_INLINE bool containslanguageSubtagMatchingRange(StringView language, StringView range, unsigned languageLength, unsigned& position)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
