Title: [190733] trunk/LayoutTests
- Revision
- 190733
- Author
- [email protected]
- Date
- 2015-10-08 10:44:18 -0700 (Thu, 08 Oct 2015)
Log Message
fast/events/scroll-after-click-on-tab-index.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149859
Reviewed by Simon Fraser.
* fast/events/scroll-after-click-on-tab-index-expected.txt:
* fast/events/scroll-after-click-on-tab-index.html:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (190732 => 190733)
--- trunk/LayoutTests/ChangeLog 2015-10-08 17:40:09 UTC (rev 190732)
+++ trunk/LayoutTests/ChangeLog 2015-10-08 17:44:18 UTC (rev 190733)
@@ -1,3 +1,14 @@
+2015-10-08 Alexey Proskuryakov <[email protected]>
+
+ fast/events/scroll-after-click-on-tab-index.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=149859
+
+ Reviewed by Simon Fraser.
+
+ * fast/events/scroll-after-click-on-tab-index-expected.txt:
+ * fast/events/scroll-after-click-on-tab-index.html:
+ * platform/mac/TestExpectations:
+
2015-10-08 Jiewen Tan <[email protected]>
Add NULL check for renderBox::layer() on applying zoom level change
Modified: trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt (190732 => 190733)
--- trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt 2015-10-08 17:40:09 UTC (rev 190732)
+++ trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index-expected.txt 2015-10-08 17:44:18 UTC (rev 190733)
@@ -1,10 +1,9 @@
ALERT: Scroll position 0
Click the text below and then try to scroll.
+PASS Scroll position is more than 0
PASS successfullyParsed is true
TEST COMPLETE
-Scroll position is more than 0
-PASS document.body.scrollTop > 0 is true
Modified: trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index.html (190732 => 190733)
--- trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index.html 2015-10-08 17:40:09 UTC (rev 190732)
+++ trunk/LayoutTests/fast/events/scroll-after-click-on-tab-index.html 2015-10-08 17:44:18 UTC (rev 190733)
@@ -1,5 +1,5 @@
<html>
-<script src=""
+<script src=""
<script>
function getCenterFor(element)
{
@@ -14,8 +14,7 @@
if (!window.eventSender)
return;
- testRunner.waitUntilDone();
- testRunner.dumpAsText();
+ jsTestIsAsync = true;
alert("Scroll position " + document.body.scrollTop);
center = getCenterFor(document.getElementById("sp"));
@@ -23,14 +22,23 @@
eventSender.mouseDown();
eventSender.mouseUp();
eventSender.keyDown("downArrow");
- setTimeout(verifyScrolling, 15);
+ intervalID = setInterval(function() {
+ if (document.body.scrollTop > 0) {
+ testPassed("Scroll position is more than 0");
+ done();
+ }
+ }, 10);
+ timeoutID = setTimeout(function() {
+ testFailed("Scroll position was still 10 after 20 seconds");
+ done();
+ }, 20000);
}
-function verifyScrolling()
+function done()
{
- debug("Scroll position is more than 0");
- shouldBe("document.body.scrollTop > 0", "true");
- testRunner.notifyDone();
+ clearInterval(intervalID);
+ clearTimeout(timeoutID);
+ finishJSTest();
}
</script>
@@ -39,7 +47,6 @@
<body _onload_="runTest();">
<input type="radio" id="myradio">Click the text below and then try to scroll.<br>
<div id="console"></div>
-<script src=""
<br><br><br><br><br><br><br><br><br><br>
<span tabindex=1 id="sp">My span</span>
<br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br><br>
Modified: trunk/LayoutTests/platform/mac/TestExpectations (190732 => 190733)
--- trunk/LayoutTests/platform/mac/TestExpectations 2015-10-08 17:40:09 UTC (rev 190732)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-10-08 17:44:18 UTC (rev 190733)
@@ -1334,6 +1334,3 @@
# Marking test as flaky in El Capitan
webkit.org/b/149819 [ Debug ElCapitan+ ] compositing/video/video-poster.html [ Pass Crash ]
-
-# Marking test as flaky
-webkit.org/b/149859 fast/events/scroll-after-click-on-tab-index.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
