Title: [190755] trunk/Source/WebCore
Revision
190755
Author
[email protected]
Date
2015-10-08 15:59:15 -0700 (Thu, 08 Oct 2015)

Log Message

data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829

Reviewed by Darin Adler.

Fix review comments after r190605:
Use protocolIs() instead of String::startsWith().

* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (190754 => 190755)


--- trunk/Source/WebCore/ChangeLog	2015-10-08 22:53:51 UTC (rev 190754)
+++ trunk/Source/WebCore/ChangeLog	2015-10-08 22:59:15 UTC (rev 190755)
@@ -1,5 +1,18 @@
 2015-10-08  Chris Dumez  <[email protected]>
 
+        data: URLs should not be preloaded
+        https://bugs.webkit.org/show_bug.cgi?id=149829
+
+        Reviewed by Darin Adler.
+
+        Fix review comments after r190605:
+        Use protocolIs() instead of String::startsWith().
+
+        * html/parser/HTMLPreloadScanner.cpp:
+        (WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
+
+2015-10-08  Chris Dumez  <[email protected]>
+
         Revert r187626 (and r188025) as it caused a PLT regression
         https://bugs.webkit.org/show_bug.cgi?id=149898
         <rdar://problem/22657123>

Modified: trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp (190754 => 190755)


--- trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp	2015-10-08 22:53:51 UTC (rev 190754)
+++ trunk/Source/WebCore/html/parser/HTMLPreloadScanner.cpp	2015-10-08 22:59:15 UTC (rev 190755)
@@ -237,7 +237,7 @@
         if (m_urlToLoad.isEmpty())
             return false;
 
-        if (m_urlToLoad.startsWith("data:", false))
+        if (protocolIs(m_urlToLoad, "data"))
             return false;
 
         if (m_tagId == TagId::Link && !m_linkIsStyleSheet)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to