Diff
Modified: trunk/Source/WebCore/ChangeLog (190802 => 190803)
--- trunk/Source/WebCore/ChangeLog 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/ChangeLog 2015-10-09 17:04:41 UTC (rev 190803)
@@ -1,3 +1,31 @@
+2015-10-09 Csaba Osztrogonác <[email protected]>
+
+ Fix the binding generator after r190785
+ https://bugs.webkit.org/show_bug.cgi?id=149956
+
+ Reviewed by Darin Adler.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (GenerateConstructorHelperMethods):
+ * bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
+ (WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData):
+ * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
+ (WebCore::JSTestEventConstructorConstructor::getConstructData):
+ * bindings/scripts/test/JS/JSTestInterface.cpp:
+ (WebCore::JSTestInterfaceConstructor::getConstructData):
+ * bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
+ (WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):
+ * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
+ (WebCore::JSTestNamedConstructorNamedConstructor::getConstructData):
+ * bindings/scripts/test/JS/JSTestNode.cpp:
+ (WebCore::JSTestNodeConstructor::getConstructData):
+ * bindings/scripts/test/JS/JSTestObj.cpp:
+ (WebCore::JSTestObjConstructor::getConstructData):
+ * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
+ (WebCore::JSTestOverloadedConstructorsConstructor::getConstructData):
+ * bindings/scripts/test/JS/JSTestTypedefs.cpp:
+ (WebCore::JSTestTypedefsConstructor::getConstructData):
+
2015-10-08 Wenson Hsieh <[email protected]>
Backgrounds bleed out of natively rendered text fields
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (190802 => 190803)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-10-09 17:04:41 UTC (rev 190803)
@@ -5009,16 +5009,18 @@
if (IsConstructable($interface)) {
if (!$interface->extendedAttributes->{"NamedConstructor"} || $generatingNamedConstructor) {
my $conditionalString = $codeGenerator->GenerateConstructorConditionalString($interface);
- push(@$outputArray, "ConstructType ${constructorClassName}::getConstructData(JSCell*, ConstructData& constructData)\n");
+ push(@$outputArray, "ConstructType ${constructorClassName}::getConstructData(JSCell* cell, ConstructData& constructData)\n");
push(@$outputArray, "{\n");
if ($conditionalString) {
push(@$outputArray, "#if $conditionalString\n");
+ push(@$outputArray, " UNUSED_PARAM(cell);\n");
push(@$outputArray, " constructData.native.function = construct;\n");
push(@$outputArray, " return ConstructTypeHost;\n");
push(@$outputArray, "#else\n");
push(@$outputArray, " return Base::getConstructData(cell, constructData);\n");
push(@$outputArray, "#endif\n");
} else {
+ push(@$outputArray, " UNUSED_PARAM(cell);\n");
push(@$outputArray, " constructData.native.function = construct;\n");
push(@$outputArray, " return ConstructTypeHost;\n");
}
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp (190802 => 190803)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp 2015-10-09 17:04:41 UTC (rev 190803)
@@ -102,8 +102,9 @@
putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
}
-ConstructType JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestCustomConstructorWithNoInterfaceObjectConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
{
+ UNUSED_PARAM(cell);
constructData.native.function = construct;
return ConstructTypeHost;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp (190802 => 190803)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp 2015-10-09 17:04:41 UTC (rev 190803)
@@ -144,8 +144,9 @@
putDirect(vm, vm.propertyNames->length, jsNumber(1), ReadOnly | DontEnum);
}
-ConstructType JSTestEventConstructorConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestEventConstructorConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
{
+ UNUSED_PARAM(cell);
constructData.native.function = construct;
return ConstructTypeHost;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp (190802 => 190803)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestInterface.cpp 2015-10-09 17:04:41 UTC (rev 190803)
@@ -302,9 +302,10 @@
reifyStaticProperties(vm, JSTestInterfaceConstructorTableValues, *this);
}
-ConstructType JSTestInterfaceConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestInterfaceConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
{
#if ENABLE(TEST_INTERFACE)
+ UNUSED_PARAM(cell);
constructData.native.function = construct;
return ConstructTypeHost;
#else
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp (190802 => 190803)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp 2015-10-09 17:04:41 UTC (rev 190803)
@@ -105,8 +105,9 @@
setInitializeFunction(vm, *JSC::JSFunction::createBuiltinFunction(vm, testJSBuiltinConstructorInitializeTestJSBuiltinConstructorCodeGenerator(vm), &globalObject));
}
-ConstructType JSTestJSBuiltinConstructorConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestJSBuiltinConstructorConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
{
+ UNUSED_PARAM(cell);
constructData.native.function = construct;
return ConstructTypeHost;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp (190802 => 190803)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cpp 2015-10-09 17:04:41 UTC (rev 190803)
@@ -161,8 +161,9 @@
putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
}
-ConstructType JSTestNamedConstructorNamedConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestNamedConstructorNamedConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
{
+ UNUSED_PARAM(cell);
constructData.native.function = construct;
return ConstructTypeHost;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp (190802 => 190803)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp 2015-10-09 17:04:41 UTC (rev 190803)
@@ -110,8 +110,9 @@
putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
}
-ConstructType JSTestNodeConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestNodeConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
{
+ UNUSED_PARAM(cell);
constructData.native.function = construct;
return ConstructTypeHost;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp (190802 => 190803)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2015-10-09 17:04:41 UTC (rev 190803)
@@ -500,8 +500,9 @@
reifyStaticProperties(vm, JSTestObjConstructorTableValues, *this);
}
-ConstructType JSTestObjConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestObjConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
{
+ UNUSED_PARAM(cell);
constructData.native.function = construct;
return ConstructTypeHost;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp (190802 => 190803)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp 2015-10-09 17:04:41 UTC (rev 190803)
@@ -177,8 +177,9 @@
putDirect(vm, vm.propertyNames->length, jsNumber(0), ReadOnly | DontEnum);
}
-ConstructType JSTestOverloadedConstructorsConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestOverloadedConstructorsConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
{
+ UNUSED_PARAM(cell);
constructData.native.function = construct;
return ConstructTypeHost;
}
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp (190802 => 190803)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2015-10-09 16:52:46 UTC (rev 190802)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestTypedefs.cpp 2015-10-09 17:04:41 UTC (rev 190803)
@@ -174,8 +174,9 @@
reifyStaticProperties(vm, JSTestTypedefsConstructorTableValues, *this);
}
-ConstructType JSTestTypedefsConstructor::getConstructData(JSCell*, ConstructData& constructData)
+ConstructType JSTestTypedefsConstructor::getConstructData(JSCell* cell, ConstructData& constructData)
{
+ UNUSED_PARAM(cell);
constructData.native.function = construct;
return ConstructTypeHost;
}
