Title: [190932] releases/WebKitGTK/webkit-2.10/Tools
- Revision
- 190932
- Author
- [email protected]
- Date
- 2015-10-13 02:01:21 -0700 (Tue, 13 Oct 2015)
Log Message
Merge r190046 - [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
https://bugs.webkit.org/show_bug.cgi?id=149252
Reviewed by Darin Adler.
In case of glib tests the test runner notifies about tests
crashing, but for google tests we don't get any feedback, which
means that in case of a test crashing we get a list of **PASS**
messages and at the summary we are notified that the test suite
has failed, but it's impossible to know which test cases have failed.
* Scripts/run-gtk-tests:
(TestRunner._run_google_test): Add a **CRASH** message if test
case crashed.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.10/Tools/ChangeLog (190931 => 190932)
--- releases/WebKitGTK/webkit-2.10/Tools/ChangeLog 2015-10-13 08:53:44 UTC (rev 190931)
+++ releases/WebKitGTK/webkit-2.10/Tools/ChangeLog 2015-10-13 09:01:21 UTC (rev 190932)
@@ -1,3 +1,20 @@
+2015-09-21 Carlos Garcia Campos <[email protected]>
+
+ [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
+ https://bugs.webkit.org/show_bug.cgi?id=149252
+
+ Reviewed by Darin Adler.
+
+ In case of glib tests the test runner notifies about tests
+ crashing, but for google tests we don't get any feedback, which
+ means that in case of a test crashing we get a list of **PASS**
+ messages and at the summary we are notified that the test suite
+ has failed, but it's impossible to know which test cases have failed.
+
+ * Scripts/run-gtk-tests:
+ (TestRunner._run_google_test): Add a **CRASH** message if test
+ case crashed.
+
2015-08-27 Filip Pizlo <[email protected]>
Unreviewed, further shorten a test that times out because it's very long
Modified: releases/WebKitGTK/webkit-2.10/Tools/Scripts/run-gtk-tests (190931 => 190932)
--- releases/WebKitGTK/webkit-2.10/Tools/Scripts/run-gtk-tests 2015-10-13 08:53:44 UTC (rev 190931)
+++ releases/WebKitGTK/webkit-2.10/Tools/Scripts/run-gtk-tests 2015-10-13 09:01:21 UTC (rev 190932)
@@ -347,8 +347,13 @@
timeout = self._options.timeout
if subtest in TestRunner.SLOW:
timeout *= 5
- return self._run_test_command(test_command, timeout)
+ status = self._run_test_command(test_command, timeout)
+ if status == -SIGSEGV:
+ sys.stdout.write("**CRASH** %s\n" % subtest)
+ sys.stdout.flush()
+ return status
+
def _run_google_test_suite(self, test_program):
retcode = 0
for subtest in self._get_tests_from_google_test_suite(test_program):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
