Title: [190988] releases/WebKitGTK/webkit-2.10/Source/WebKit2
Revision
190988
Author
[email protected]
Date
2015-10-13 08:09:31 -0700 (Tue, 13 Oct 2015)

Log Message

Merge r190930 - Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize()
https://bugs.webkit.org/show_bug.cgi?id=150061

Reviewed by Carlos Garcia Campos.

Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize().
Key::HashType is currently a SHA1::Digest, which is a std::array<uint8_t, 20>.

* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::synchronize):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog (190987 => 190988)


--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog	2015-10-13 14:42:23 UTC (rev 190987)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/ChangeLog	2015-10-13 15:09:31 UTC (rev 190988)
@@ -1,3 +1,16 @@
+2015-10-13  Chris Dumez  <[email protected]>
+
+        Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize()
+        https://bugs.webkit.org/show_bug.cgi?id=150061
+
+        Reviewed by Carlos Garcia Campos.
+
+        Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize().
+        Key::HashType is currently a SHA1::Digest, which is a std::array<uint8_t, 20>.
+
+        * NetworkProcess/cache/NetworkCacheStorage.cpp:
+        (WebKit::NetworkCache::Storage::synchronize):
+
 2015-09-17  Michael Catanzaro  <[email protected]>
 
         [GTK] Crash in WebKit::BackingStore::createBackend running under Wayland

Modified: releases/WebKitGTK/webkit-2.10/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp (190987 => 190988)


--- releases/WebKitGTK/webkit-2.10/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp	2015-10-13 14:42:23 UTC (rev 190987)
+++ releases/WebKitGTK/webkit-2.10/Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp	2015-10-13 15:09:31 UTC (rev 190988)
@@ -259,11 +259,11 @@
             auto recordFilter = std::unique_ptr<ContentsFilter>(recordFilterPtr);
             auto bodyFilter = std::unique_ptr<ContentsFilter>(bodyFilterPtr);
 
-            for (auto hash : m_recordFilterHashesAddedDuringSynchronization)
+            for (auto& hash : m_recordFilterHashesAddedDuringSynchronization)
                 recordFilter->add(hash);
             m_recordFilterHashesAddedDuringSynchronization.clear();
 
-            for (auto hash : m_bodyFilterHashesAddedDuringSynchronization)
+            for (auto& hash : m_bodyFilterHashesAddedDuringSynchronization)
                 bodyFilter->add(hash);
             m_bodyFilterHashesAddedDuringSynchronization.clear();
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to