Diff
Modified: trunk/LayoutTests/ChangeLog (191205 => 191206)
--- trunk/LayoutTests/ChangeLog 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/LayoutTests/ChangeLog 2015-10-16 21:06:00 UTC (rev 191206)
@@ -1,3 +1,14 @@
+2015-10-16 Michael Saboff <msab...@apple.com>
+
+ REGRESSION (r191175): Still crashing when clicking back button on netflix.com
+ https://bugs.webkit.org/show_bug.cgi?id=150251
+
+ Rubber stamped by Filip Pizlo.
+
+ Turning off Tail Calls and disabling tests until the crash is fixed.
+
+ * js/caller-property-expected.txt:
+
2015-10-16 Antti Koivisto <an...@apple.com>
Computed style should work correctly with slotted elements that have display:none
Modified: trunk/LayoutTests/js/caller-property-expected.txt (191205 => 191206)
--- trunk/LayoutTests/js/caller-property-expected.txt 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/LayoutTests/js/caller-property-expected.txt 2015-10-16 21:06:00 UTC (rev 191206)
@@ -10,13 +10,13 @@
PASS nonStrictCaller(strictCallee) threw exception TypeError: Type error.
PASS strictCaller(nonStrictCallee) threw exception TypeError: Function.caller used to retrieve strict caller.
PASS strictCaller(strictCallee) threw exception TypeError: Type error.
-PASS strictTailCaller(nonStrictCallee) is null
+FAIL strictTailCaller(nonStrictCallee) should be null. Threw exception TypeError: Function.caller used to retrieve strict caller
PASS strictTailCaller(strictCallee) threw exception TypeError: Type error.
PASS nonStrictCaller(boundNonStrictCallee) is nonStrictCaller
PASS nonStrictCaller(boundStrictCallee) threw exception TypeError: Type error.
PASS strictCaller(boundNonStrictCallee) threw exception TypeError: Function.caller used to retrieve strict caller.
PASS strictCaller(boundStrictCallee) threw exception TypeError: Type error.
-PASS strictTailCaller(boundNonStrictCallee) is null
+FAIL strictTailCaller(boundNonStrictCallee) should be null. Threw exception TypeError: Function.caller used to retrieve strict caller
PASS strictTailCaller(boundStrictCallee) threw exception TypeError: Type error.
PASS nonStrictGetter(nonStrictAccessor) is nonStrictGetter
PASS nonStrictSetter(nonStrictAccessor) is true
Modified: trunk/Source/_javascript_Core/ChangeLog (191205 => 191206)
--- trunk/Source/_javascript_Core/ChangeLog 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-10-16 21:06:00 UTC (rev 191206)
@@ -1,3 +1,27 @@
+2015-10-16 Michael Saboff <msab...@apple.com>
+
+ REGRESSION (r191175): Still crashing when clicking back button on netflix.com
+ https://bugs.webkit.org/show_bug.cgi?id=150251
+
+ Rubber stamped by Filip Pizlo.
+
+ Turning off Tail Calls and disabling tests until the crash is fixed.
+
+ * runtime/Options.h:
+ * tests/es6.yaml:
+ * tests/stress/dfg-tail-calls.js:
+ (nonInlinedTailCall.callee):
+ * tests/stress/mutual-tail-call-no-stack-overflow.js:
+ (shouldThrow):
+ * tests/stress/tail-call-in-inline-cache.js:
+ (tail):
+ * tests/stress/tail-call-no-stack-overflow.js:
+ (shouldThrow):
+ * tests/stress/tail-call-recognize.js:
+ (callerMustBeRun):
+ * tests/stress/tail-call-varargs-no-stack-overflow.js:
+ (shouldThrow):
+
2015-10-16 Mark Lam <mark....@apple.com>
Add MacroAssembler::callProbe() for supporting lambda JIT probes.
Modified: trunk/Source/_javascript_Core/runtime/Options.h (191205 => 191206)
--- trunk/Source/_javascript_Core/runtime/Options.h 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/Source/_javascript_Core/runtime/Options.h 2015-10-16 21:06:00 UTC (rev 191206)
@@ -131,7 +131,7 @@
v(bool, forceProfilerBytecodeGeneration, false, nullptr) \
\
v(bool, useFunctionDotArguments, true, nullptr) \
- v(bool, useTailCalls, true, nullptr) \
+ v(bool, useTailCalls, false, nullptr) \
\
/* dumpDisassembly implies dumpDFGDisassembly. */ \
v(bool, dumpDisassembly, false, "dumps disassembly of all JIT compiled code upon compilation") \
Modified: trunk/Source/_javascript_Core/tests/es6.yaml (191205 => 191206)
--- trunk/Source/_javascript_Core/tests/es6.yaml 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/Source/_javascript_Core/tests/es6.yaml 2015-10-16 21:06:00 UTC (rev 191206)
@@ -877,9 +877,9 @@
- path: es6/Promise_Promise[Symbol.species].js
cmd: runES6 :fail
- path: es6/proper_tail_calls_tail_call_optimisation_direct_recursion.js
- cmd: runES6 :normal
+ cmd: runES6 :fail
- path: es6/proper_tail_calls_tail_call_optimisation_mutual_recursion.js
- cmd: runES6 :normal
+ cmd: runES6 :fail
- path: es6/prototype_of_bound_functions_arrow_functions.js
cmd: runES6 :fail
- path: es6/prototype_of_bound_functions_basic_functions.js
Modified: trunk/Source/_javascript_Core/tests/stress/dfg-tail-calls.js (191205 => 191206)
--- trunk/Source/_javascript_Core/tests/stress/dfg-tail-calls.js 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/Source/_javascript_Core/tests/stress/dfg-tail-calls.js 2015-10-16 21:06:00 UTC (rev 191206)
@@ -1,3 +1,4 @@
+//@ skip
(function nonInlinedTailCall() {
function callee() { if (callee.caller != nonInlinedTailCall) throw new Error(); }
noInline(callee);
Modified: trunk/Source/_javascript_Core/tests/stress/mutual-tail-call-no-stack-overflow.js (191205 => 191206)
--- trunk/Source/_javascript_Core/tests/stress/mutual-tail-call-no-stack-overflow.js 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/Source/_javascript_Core/tests/stress/mutual-tail-call-no-stack-overflow.js 2015-10-16 21:06:00 UTC (rev 191206)
@@ -1,3 +1,4 @@
+//@ skip
function shouldThrow(func, errorMessage) {
var errorThrown = false;
var error = null;
Modified: trunk/Source/_javascript_Core/tests/stress/tail-call-in-inline-cache.js (191205 => 191206)
--- trunk/Source/_javascript_Core/tests/stress/tail-call-in-inline-cache.js 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/Source/_javascript_Core/tests/stress/tail-call-in-inline-cache.js 2015-10-16 21:06:00 UTC (rev 191206)
@@ -1,3 +1,4 @@
+//@ skip
"use strict";
function tail() { }
Modified: trunk/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js (191205 => 191206)
--- trunk/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/Source/_javascript_Core/tests/stress/tail-call-no-stack-overflow.js 2015-10-16 21:06:00 UTC (rev 191206)
@@ -1,3 +1,4 @@
+//@ skip
function shouldThrow(func, errorMessage) {
var errorThrown = false;
var error = null;
Modified: trunk/Source/_javascript_Core/tests/stress/tail-call-recognize.js (191205 => 191206)
--- trunk/Source/_javascript_Core/tests/stress/tail-call-recognize.js 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/Source/_javascript_Core/tests/stress/tail-call-recognize.js 2015-10-16 21:06:00 UTC (rev 191206)
@@ -1,3 +1,4 @@
+//@ skip
function callerMustBeRun() {
if (!Object.is(callerMustBeRun.caller, runTests))
throw Error("Wrong caller, expected run but got ", callerMustBeRun.caller);
Modified: trunk/Source/_javascript_Core/tests/stress/tail-call-varargs-no-stack-overflow.js (191205 => 191206)
--- trunk/Source/_javascript_Core/tests/stress/tail-call-varargs-no-stack-overflow.js 2015-10-16 21:02:33 UTC (rev 191205)
+++ trunk/Source/_javascript_Core/tests/stress/tail-call-varargs-no-stack-overflow.js 2015-10-16 21:06:00 UTC (rev 191206)
@@ -1,3 +1,4 @@
+//@ skip
function shouldThrow(func, errorMessage) {
var errorThrown = false;
var error = null;
