Title: [191345] trunk/Tools
- Revision
- 191345
- Author
- [email protected]
- Date
- 2015-10-20 10:19:22 -0700 (Tue, 20 Oct 2015)
Log Message
Mac Debug EWS never finishes when there are failures
https://bugs.webkit.org/show_bug.cgi?id=150334
Reviewed by Daniel Bates.
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
* Scripts/webkitpy/tool/commands/queues.py:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (191344 => 191345)
--- trunk/Tools/ChangeLog 2015-10-20 17:16:15 UTC (rev 191344)
+++ trunk/Tools/ChangeLog 2015-10-20 17:19:22 UTC (rev 191345)
@@ -1,3 +1,13 @@
+2015-10-20 Alexey Proskuryakov <[email protected]>
+
+ Mac Debug EWS never finishes when there are failures
+ https://bugs.webkit.org/show_bug.cgi?id=150334
+
+ Reviewed by Daniel Bates.
+
+ * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+ * Scripts/webkitpy/tool/commands/queues.py:
+
2015-10-20 Philippe Normand <[email protected]>
[GTK] Enable OpenWebRTC test video/audio sources in tests
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (191344 => 191345)
--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2015-10-20 17:16:15 UTC (rev 191344)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py 2015-10-20 17:19:22 UTC (rev 191345)
@@ -45,6 +45,7 @@
# Needed to define port_name, used in AbstractEarlyWarningSystem.__init__
class TestEWS(AbstractEarlyWarningSystem):
port_name = "win" # Needs to be a port which port/factory understands.
+ _build_style = None
ews = TestEWS()
ews.bind_to_tool(MockTool())
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues.py (191344 => 191345)
--- trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2015-10-20 17:16:15 UTC (rev 191344)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues.py 2015-10-20 17:19:22 UTC (rev 191345)
@@ -250,7 +250,10 @@
def work_item_log_path(self, patch):
return os.path.join(self._log_directory(), "%s.log" % patch.bug_id())
+ def build_style(self):
+ return "release"
+
# Used to share code between the EWS and commit-queue.
class PatchProcessingQueue(AbstractPatchQueue):
# Subclasses must override.
@@ -269,6 +272,15 @@
return 'win-future'
return port_name
+ def _create_port(self):
+ self._port = self._tool.port_factory.get(self._new_port_name_from_old(self.port_name, self._tool.platform))
+ if self.architecture:
+ self._port.set_architecture(self.architecture)
+ if self.build_style() == "debug":
+ self._port.set_option("configuration", "Debug")
+ else:
+ self._port.set_option("configuration", "Release")
+
def begin_work_queue(self):
AbstractPatchQueue.begin_work_queue(self)
if not self.port_name:
@@ -278,13 +290,11 @@
# FIXME: This violates abstraction
self._tool._deprecated_port = self._deprecated_port
- self._port = self._tool.port_factory.get(self._new_port_name_from_old(self.port_name, self._tool.platform))
- if self.architecture:
- self._port.set_architecture(self.architecture)
+ self._create_port()
def _upload_results_archive_for_patch(self, patch, results_archive_zip):
if not self._port:
- self._port = self._tool.port_factory.get(self._new_port_name_from_old(self.port_name, self._tool.platform))
+ self._create_port()
bot_id = self._tool.status_server.bot_id or "bot"
description = "Archive of layout-test-results from %s for %s" % (bot_id, self._port.name())
@@ -382,9 +392,6 @@
def archive_last_test_results(self, patch):
return self._layout_test_results_reader.archive(patch)
- def build_style(self):
- return "release"
-
def refetch_patch(self, patch):
return self._tool.bugs.fetch_attachment(patch.id())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
