Title: [191398] trunk
- Revision
- 191398
- Author
- [email protected]
- Date
- 2015-10-21 13:04:12 -0700 (Wed, 21 Oct 2015)
Log Message
bgsound should use HTMLUnknownElement interface
https://bugs.webkit.org/show_bug.cgi?id=148857
<rdar://problem/22589036>
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline a couple of W3C HTML tests now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
* web-platform-tests/html/semantics/interfaces-expected.txt:
Source/WebCore:
The blink, bgsound, isindex, multicol, nextid, and spacer elements must
use the HTMLUnknownElement interface, as per the HTML specification:
https://html.spec.whatwg.org/multipage/obsolete.html#other-elements,-attributes-and-apis
WebKit was using HTMLUnknownElement for all of them except bgsound.
This patch fixes the issue and aligns our behavior with Chrome and
Firefox.
No new tests, already covered by existing tests.
* html/HTMLTagNames.in:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (191397 => 191398)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2015-10-21 20:04:12 UTC (rev 191398)
@@ -1,3 +1,16 @@
+2015-10-21 Chris Dumez <[email protected]>
+
+ bgsound should use HTMLUnknownElement interface
+ https://bugs.webkit.org/show_bug.cgi?id=148857
+ <rdar://problem/22589036>
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline a couple of W3C HTML tests now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+ * web-platform-tests/html/semantics/interfaces-expected.txt:
+
2015-10-21 Youenn Fablet <[email protected]>
W3C test importer should not import reference files as regular tests
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (191397 => 191398)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2015-10-21 20:04:12 UTC (rev 191398)
@@ -148,10 +148,6 @@
CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
CONSOLE MESSAGE: line 794: Deprecated attempt to access property 'nodeType' on a non-Node object.
CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 794: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 794: Deprecated attempt to access property 'nodeType' on a non-Node object.
-CONSOLE MESSAGE: line 2476: Deprecated attempt to access property 'nodeType' on a non-Node object.
CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'version' on a non-HTMLHtmlElement object.
CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'text' on a non-HTMLTitleElement object.
CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'href' on a non-HTMLBaseElement object.
@@ -2230,8 +2226,8 @@
PASS Stringification of document.createElement("blink")
PASS HTMLUnknownElement must be primary interface of document.createElement("quasit")
PASS Stringification of document.createElement("quasit")
-FAIL HTMLUnknownElement must be primary interface of document.createElement("bgsound") assert_equals: document.createElement("bgsound")'s prototype is not HTMLUnknownElement.prototype expected Node object of unknown type but got Node object of unknown type
-FAIL Stringification of document.createElement("bgsound") assert_equals: class string of document.createElement("bgsound") expected "[object HTMLUnknownElement]" but got "[object HTMLElement]"
+PASS HTMLUnknownElement must be primary interface of document.createElement("bgsound")
+PASS Stringification of document.createElement("bgsound")
PASS HTMLUnknownElement must be primary interface of document.createElement("isindex")
PASS Stringification of document.createElement("isindex")
PASS HTMLUnknownElement must be primary interface of document.createElement("multicol")
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt (191397 => 191398)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt 2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt 2015-10-21 20:04:12 UTC (rev 191398)
@@ -17,8 +17,8 @@
FAIL Interfaces for BASEFONT assert_equals: Element BASEFONT should have HTMLUnknownElement as its primary interface. expected "[object HTMLUnknownElement]" but got "[object HTMLBaseFontElement]"
PASS Interfaces for bdo
PASS Interfaces for BDO
-FAIL Interfaces for bgsound assert_equals: Element bgsound should have HTMLUnknownElement as its primary interface. expected "[object HTMLUnknownElement]" but got "[object HTMLElement]"
-FAIL Interfaces for BGSOUND assert_equals: Element BGSOUND should have HTMLUnknownElement as its primary interface. expected "[object HTMLUnknownElement]" but got "[object HTMLElement]"
+PASS Interfaces for bgsound
+PASS Interfaces for BGSOUND
PASS Interfaces for big
PASS Interfaces for BIG
PASS Interfaces for blink
Modified: trunk/Source/WebCore/ChangeLog (191397 => 191398)
--- trunk/Source/WebCore/ChangeLog 2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/Source/WebCore/ChangeLog 2015-10-21 20:04:12 UTC (rev 191398)
@@ -1,3 +1,23 @@
+2015-10-21 Chris Dumez <[email protected]>
+
+ bgsound should use HTMLUnknownElement interface
+ https://bugs.webkit.org/show_bug.cgi?id=148857
+ <rdar://problem/22589036>
+
+ Reviewed by Sam Weinig.
+
+ The blink, bgsound, isindex, multicol, nextid, and spacer elements must
+ use the HTMLUnknownElement interface, as per the HTML specification:
+ https://html.spec.whatwg.org/multipage/obsolete.html#other-elements,-attributes-and-apis
+
+ WebKit was using HTMLUnknownElement for all of them except bgsound.
+ This patch fixes the issue and aligns our behavior with Chrome and
+ Firefox.
+
+ No new tests, already covered by existing tests.
+
+ * html/HTMLTagNames.in:
+
2015-10-21 Antoine Quint <[email protected]>
Support for the SVG `onend` attribute
Modified: trunk/Source/WebCore/html/HTMLTagNames.in (191397 => 191398)
--- trunk/Source/WebCore/html/HTMLTagNames.in 2015-10-21 19:56:50 UTC (rev 191397)
+++ trunk/Source/WebCore/html/HTMLTagNames.in 2015-10-21 20:04:12 UTC (rev 191398)
@@ -18,7 +18,7 @@
basefont interfaceName=HTMLBaseFontElement
bdi interfaceName=HTMLBDIElement, JSInterfaceName=HTMLElement
bdo interfaceName=HTMLElement
-bgsound interfaceName=HTMLElement
+bgsound interfaceName=HTMLUnknownElement
big interfaceName=HTMLElement
blockquote interfaceName=HTMLQuoteElement
body
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
