Title: [191503] trunk/Source/WebKit2
Revision
191503
Author
[email protected]
Date
2015-10-23 11:41:17 -0700 (Fri, 23 Oct 2015)

Log Message

[GTK] Minor web editor fixes
https://bugs.webkit.org/show_bug.cgi?id=150501

Reviewed by Carlos Garcia Campos.

* UIProcess/gtk/KeyBindingTranslator.cpp: Remove
"MoveParagraphForward/Backward" as these commands do not exist in
WebKit (anymore?).
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::executePendingEditorCommands):
Editor::Command can take a String, no need to convert to a C char.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (191502 => 191503)


--- trunk/Source/WebKit2/ChangeLog	2015-10-23 18:29:45 UTC (rev 191502)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-23 18:41:17 UTC (rev 191503)
@@ -1,3 +1,17 @@
+2015-10-23  Claudio Saavedra  <[email protected]>
+
+        [GTK] Minor web editor fixes
+        https://bugs.webkit.org/show_bug.cgi?id=150501
+
+        Reviewed by Carlos Garcia Campos.
+
+        * UIProcess/gtk/KeyBindingTranslator.cpp: Remove
+        "MoveParagraphForward/Backward" as these commands do not exist in
+        WebKit (anymore?).
+        * WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
+        (WebKit::WebEditorClient::executePendingEditorCommands):
+        Editor::Command can take a String, no need to convert to a C char.
+
 2015-10-23  Timothy Horton  <[email protected]>
 
         Fix the build by unapplying review comments.

Modified: trunk/Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp (191502 => 191503)


--- trunk/Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp	2015-10-23 18:29:45 UTC (rev 191502)
+++ trunk/Source/WebKit2/UIProcess/gtk/KeyBindingTranslator.cpp	2015-10-23 18:41:17 UTC (rev 191503)
@@ -130,7 +130,7 @@
       "MoveUpAndModifySelection",                       "MoveDownAndModifySelection"                }, // Up/down line
     { "MoveToBeginningOfLine",                          "MoveToEndOfLine",
       "MoveToBeginningOfLineAndModifySelection",        "MoveToEndOfLineAndModifySelection"         }, // Up/down line ends
-    { "MoveParagraphBackward",                          "MoveParagraphForward",
+    { 0,                                                0,
       "MoveParagraphBackwardAndModifySelection",        "MoveParagraphForwardAndModifySelection"    }, // Up/down paragraphs
     { "MoveToBeginningOfParagraph",                     "MoveToEndOfParagraph",
       "MoveToBeginningOfParagraphAndModifySelection",   "MoveToEndOfParagraphAndModifySelection"    }, // Up/down paragraph ends.

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp (191502 => 191503)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp	2015-10-23 18:29:45 UTC (rev 191502)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp	2015-10-23 18:41:17 UTC (rev 191503)
@@ -39,7 +39,7 @@
 {
     Vector<Editor::Command> commands;
     for (auto& commandString : pendingEditorCommands) {
-        Editor::Command command = frame->editor().command(commandString.utf8().data());
+        Editor::Command command = frame->editor().command(commandString);
         if (command.isTextInsertion() && !allowTextInsertion)
             return false;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to