Title: [191618] trunk/Source/WebKit2
Revision
191618
Author
[email protected]
Date
2015-10-26 22:15:50 -0700 (Mon, 26 Oct 2015)

Log Message

[GTK] [Stable] InstallMissingMediaPluginsPermissionRequest not defined when building without GStreamer
https://bugs.webkit.org/show_bug.cgi?id=148607

Unreviewed, build fix.

Patch by Philip Chimento <[email protected]> on 2015-10-26

* UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h:
Add a stub for the InstallMissingMediaPluginsPermissionRequest class
for the case when video is disabled or not using GStreamer. It's OK
that this class does nothing, because the associated C API contains
an assert_not_reached if video is disabled. We just need to define
the symbol so that the function signature will compile.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (191617 => 191618)


--- trunk/Source/WebKit2/ChangeLog	2015-10-27 04:03:38 UTC (rev 191617)
+++ trunk/Source/WebKit2/ChangeLog	2015-10-27 05:15:50 UTC (rev 191618)
@@ -1,3 +1,17 @@
+2015-10-26  Philip Chimento  <[email protected]>
+
+        [GTK] [Stable] InstallMissingMediaPluginsPermissionRequest not defined when building without GStreamer
+        https://bugs.webkit.org/show_bug.cgi?id=148607
+
+        Unreviewed, build fix.
+
+        * UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h:
+        Add a stub for the InstallMissingMediaPluginsPermissionRequest class
+        for the case when video is disabled or not using GStreamer. It's OK
+        that this class does nothing, because the associated C API contains
+        an assert_not_reached if video is disabled. We just need to define
+        the symbol so that the function signature will compile.
+
 2015-10-26  Anders Carlsson  <[email protected]>
 
         Pipe custom context menu handling through to the UIDelegate object

Modified: trunk/Source/WebKit2/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h (191617 => 191618)


--- trunk/Source/WebKit2/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h	2015-10-27 04:03:38 UTC (rev 191617)
+++ trunk/Source/WebKit2/UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h	2015-10-27 05:15:50 UTC (rev 191618)
@@ -63,5 +63,11 @@
 
 } // namespace WebKit
 
+#else
+
+namespace WebKit {
+class InstallMissingMediaPluginsPermissionRequest;
+} // namespace WebKit
+
 #endif // ENABLE(VIDEO) && USE(GSTREAMER)
 #endif // InstallMissingMediaPluginsPermissionRequest_h
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to