Title: [191798] trunk/Source/WebKit2
- Revision
- 191798
- Author
- [email protected]
- Date
- 2015-10-30 10:58:49 -0700 (Fri, 30 Oct 2015)
Log Message
REGRESSION (r191691): Unexpected "Share" context menu when right clicking around inspector
https://bugs.webkit.org/show_bug.cgi?id=150699
rdar://problem/23324522
Reviewed by Tim Horton.
Don't create a share menu item if we have nothing to share.
* UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::createShareMenuItem):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (191797 => 191798)
--- trunk/Source/WebKit2/ChangeLog 2015-10-30 17:56:56 UTC (rev 191797)
+++ trunk/Source/WebKit2/ChangeLog 2015-10-30 17:58:49 UTC (rev 191798)
@@ -1,3 +1,16 @@
+2015-10-30 Anders Carlsson <[email protected]>
+
+ REGRESSION (r191691): Unexpected "Share" context menu when right clicking around inspector
+ https://bugs.webkit.org/show_bug.cgi?id=150699
+ rdar://problem/23324522
+
+ Reviewed by Tim Horton.
+
+ Don't create a share menu item if we have nothing to share.
+
+ * UIProcess/mac/WebContextMenuProxyMac.mm:
+ (WebKit::WebContextMenuProxyMac::createShareMenuItem):
+
2015-10-30 Tim Horton <[email protected]>
Initialize some new WebViewImpl members
Modified: trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm (191797 => 191798)
--- trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm 2015-10-30 17:56:56 UTC (rev 191797)
+++ trunk/Source/WebKit2/UIProcess/mac/WebContextMenuProxyMac.mm 2015-10-30 17:58:49 UTC (rev 191798)
@@ -282,6 +282,9 @@
[items addObject:image.get()];
}
+ if (![items count])
+ return nil;
+
RetainPtr<NSMenuItem> item = [NSMenuItem standardShareMenuItemWithItems:items.get()];
if (!item)
return nil;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
