Title: [191851] trunk/Source/WebCore
- Revision
- 191851
- Author
- [email protected]
- Date
- 2015-10-31 22:47:41 -0700 (Sat, 31 Oct 2015)
Log Message
Add a debug overlay with information about web process resource usage.
<https://webkit.org/b/150599>
Unreviewed follow-up to r191849.
Add missing call to uninstall the PageOverlay if the ResourceUsageOverlay is being
disabled through the setting. This way you don't end up with an unremovable overlay
in the MiniBrowser.
* page/ResourceUsageOverlay.cpp:
(WebCore::ResourceUsageOverlay::~ResourceUsageOverlay):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (191850 => 191851)
--- trunk/Source/WebCore/ChangeLog 2015-11-01 04:34:49 UTC (rev 191850)
+++ trunk/Source/WebCore/ChangeLog 2015-11-01 05:47:41 UTC (rev 191851)
@@ -1,3 +1,17 @@
+2015-10-31 Andreas Kling <[email protected]>
+
+ Add a debug overlay with information about web process resource usage.
+ <https://webkit.org/b/150599>
+
+ Unreviewed follow-up to r191849.
+
+ Add missing call to uninstall the PageOverlay if the ResourceUsageOverlay is being
+ disabled through the setting. This way you don't end up with an unremovable overlay
+ in the MiniBrowser.
+
+ * page/ResourceUsageOverlay.cpp:
+ (WebCore::ResourceUsageOverlay::~ResourceUsageOverlay):
+
2015-10-31 Brady Eidson <[email protected]>
IDB: Date objects don't work as keys or values.
Modified: trunk/Source/WebCore/page/ResourceUsageOverlay.cpp (191850 => 191851)
--- trunk/Source/WebCore/page/ResourceUsageOverlay.cpp 2015-11-01 04:34:49 UTC (rev 191850)
+++ trunk/Source/WebCore/page/ResourceUsageOverlay.cpp 2015-11-01 05:47:41 UTC (rev 191851)
@@ -50,6 +50,10 @@
ResourceUsageOverlay::~ResourceUsageOverlay()
{
platformDestroy();
+
+ // FIXME: This is a hack so we don't try to uninstall the PageOverlay during Page destruction.
+ if (m_page.mainFrame().page())
+ m_page.mainFrame().pageOverlayController().uninstallPageOverlay(m_overlay.get(), PageOverlay::FadeMode::DoNotFade);
}
bool ResourceUsageOverlay::mouseEvent(PageOverlay&, const PlatformMouseEvent& event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
