Title: [191898] trunk/LayoutTests
Revision
191898
Author
beid...@apple.com
Date
2015-11-02 10:39:17 -0800 (Mon, 02 Nov 2015)

Log Message

storage/indexeddb/modern/idbobjectstore-get-failures.html is flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=150804

Reviewed by Beth Dakin's rubberstamp.

* platform/mac-wk1/TestExpectations:
* storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html:
* storage/indexeddb/modern/idbobjectstore-count-failures.html:
* storage/indexeddb/modern/idbobjectstore-get-failures.html:
* storage/indexeddb/modern/idbobjectstore-put-and-clear-failures.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (191897 => 191898)


--- trunk/LayoutTests/ChangeLog	2015-11-02 18:32:55 UTC (rev 191897)
+++ trunk/LayoutTests/ChangeLog	2015-11-02 18:39:17 UTC (rev 191898)
@@ -1,3 +1,16 @@
+2015-11-02  Brady Eidson  <beid...@apple.com>
+
+        storage/indexeddb/modern/idbobjectstore-get-failures.html is flaky on mac-wk1
+        https://bugs.webkit.org/show_bug.cgi?id=150804
+
+        Reviewed by Beth Dakin's rubberstamp.
+
+        * platform/mac-wk1/TestExpectations:
+        * storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html:
+        * storage/indexeddb/modern/idbobjectstore-count-failures.html:
+        * storage/indexeddb/modern/idbobjectstore-get-failures.html:
+        * storage/indexeddb/modern/idbobjectstore-put-and-clear-failures.html:
+
 2015-11-02  Ryan Haddad  <ryanhad...@apple.com>
 
         Marking imported/w3c/web-platform-tests/XMLHttpRequest/send-timeout-events.htm as flaky on Mac

Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (191897 => 191898)


--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-11-02 18:32:55 UTC (rev 191897)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2015-11-02 18:39:17 UTC (rev 191898)
@@ -139,9 +139,6 @@
 
 [ ElCapitan+ ] css3/masking/mask-repeat-space-padding.html [ ImageOnlyFailure ]
 
-webkit.org/b/150804 storage/indexeddb/modern/idbobjectstore-get-failures.html [ Pass Failure ]
-webkit.org/b/150805 storage/indexeddb/modern/idbobjectstore-count-failures.html [ Pass Failure ]
-
 ### END OF (2) Failures without bug reports
 ########################################
 

Modified: trunk/LayoutTests/storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html (191897 => 191898)


--- trunk/LayoutTests/storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html	2015-11-02 18:32:55 UTC (rev 191897)
+++ trunk/LayoutTests/storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html	2015-11-02 18:39:17 UTC (rev 191898)
@@ -100,11 +100,12 @@
         } catch(e) {
             alert("Failed to deleteObjectStore with a non-existent objectstore - " + e);
         }
-        
-        // Queue up a whole bunch of puts to keep the transaction alive for awhile
+
+        // Queue up some puts to keep the transaction alive long enough for the setTimeout to fire.
         var objectStore = versionTransaction.objectStore("TestObjectStore");
-        for (var i = 0; i < 10; ++i)
-            objectStore.put("AH AH AH AH AH", i + " puts");
+        objectStore.put("we will we will", 1)._onsuccess_ = function() {
+            objectStore.put("rock you", 2);
+        }
         
         // After the versionChange transaction becomes inactive, but while it's still in-progress, try to delete the objectstore
         var tryInactiveDelete = function() 

Modified: trunk/LayoutTests/storage/indexeddb/modern/idbobjectstore-count-failures.html (191897 => 191898)


--- trunk/LayoutTests/storage/indexeddb/modern/idbobjectstore-count-failures.html	2015-11-02 18:32:55 UTC (rev 191897)
+++ trunk/LayoutTests/storage/indexeddb/modern/idbobjectstore-count-failures.html	2015-11-02 18:39:17 UTC (rev 191898)
@@ -65,9 +65,10 @@
     var transaction = database.transaction("TestObjectStore", "readonly");
     var objectStore = transaction.objectStore("TestObjectStore");
 
-    // Queue up a whole bunch of gets to keep the transaction alive for awhile
-    for (var i = 0; i < 10; ++i)
+    // Queue up some gets to keep the transaction alive long enough for the setTimeout to fire.
+    objectStore.get("foo")._onsuccess_ = function() {
         objectStore.get("foo");
+    }
 
     var getWhileInactive = function() {
         try {

Modified: trunk/LayoutTests/storage/indexeddb/modern/idbobjectstore-get-failures.html (191897 => 191898)


--- trunk/LayoutTests/storage/indexeddb/modern/idbobjectstore-get-failures.html	2015-11-02 18:32:55 UTC (rev 191897)
+++ trunk/LayoutTests/storage/indexeddb/modern/idbobjectstore-get-failures.html	2015-11-02 18:39:17 UTC (rev 191898)
@@ -65,9 +65,10 @@
     var transaction = database.transaction("TestObjectStore", "readonly");
     var objectStore = transaction.objectStore("TestObjectStore");
 
-    // Queue up a whole bunch of gets to keep the transaction alive for awhile
-    for (var i = 0; i < 10; ++i)
+    // Queue up some gets to keep the transaction alive long enough for the setTimeout to fire.
+    objectStore.get("foo")._onsuccess_ = function() {
         objectStore.get("foo");
+    }
 
     var getWhileInactive = function() {
         try {

Modified: trunk/LayoutTests/storage/indexeddb/modern/idbobjectstore-put-and-clear-failures.html (191897 => 191898)


--- trunk/LayoutTests/storage/indexeddb/modern/idbobjectstore-put-and-clear-failures.html	2015-11-02 18:32:55 UTC (rev 191897)
+++ trunk/LayoutTests/storage/indexeddb/modern/idbobjectstore-put-and-clear-failures.html	2015-11-02 18:39:17 UTC (rev 191898)
@@ -80,9 +80,10 @@
     var transaction = database.transaction("TestObjectStore", "readwrite");
     var objectStore = transaction.objectStore("TestObjectStore");
 
-    // Queue up a whole bunch of gets to keep the transaction alive for awhile
-    for (var i = 0; i < 10; ++i)
+    // Queue up some gets to keep the transaction alive long enough for the setTimeout to fire.
+    objectStore.get("foo")._onsuccess_ = function() {
         objectStore.get("foo");
+    }
 
     var testWhileInactive = function() {
         try {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to