Title: [191974] trunk/Tools
Revision
191974
Author
wenson_hs...@apple.com
Date
2015-11-03 13:40:20 -0800 (Tue, 03 Nov 2015)

Log Message

Fix touch event sending crash in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=150848
<rdar://problem/23360841>

Reviewed by Simon Fraser.

Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.

* WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]): Deleted.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (191973 => 191974)


--- trunk/Tools/ChangeLog	2015-11-03 21:37:40 UTC (rev 191973)
+++ trunk/Tools/ChangeLog	2015-11-03 21:40:20 UTC (rev 191974)
@@ -1,3 +1,16 @@
+2015-11-03  Wenson Hsieh  <wenson_hs...@apple.com>
+
+        Fix touch event sending crash in WebKitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=150848
+        <rdar://problem/23360841>
+
+        Reviewed by Simon Fraser.
+
+        Fixes a redundant force event generated by HIDEventGenerator. See the Radar diagnosis for more details.
+
+        * WebKitTestRunner/ios/HIDEventGenerator.mm:
+        (-[HIDEventGenerator _createIOHIDEventType:]): Deleted.
+
 2015-11-03  Brent Fulgham  <bfulg...@apple.com>
 
         [Win] Unreviewed build fix after r191958.

Modified: trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm (191973 => 191974)


--- trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm	2015-11-03 21:37:40 UTC (rev 191973)
+++ trunk/Tools/WebKitTestRunner/ios/HIDEventGenerator.mm	2015-11-03 21:40:20 UTC (rev 191974)
@@ -205,18 +205,6 @@
         IOHIDEventAppendEvent(eventRef.get(), subEvent.get(), 0);
     }
 
-    if (_activePointCount) {
-        IOHIDFloat progress = _activePoints[0].pathPressure;
-        RetainPtr<IOHIDEventRef> forceEvent = adoptCF(IOHIDEventCreateForceEvent(kCFAllocatorDefault,
-            machTime,
-            0,
-            progress,
-            0,
-            0.0,
-            kIOHIDEventOptionNone));
-        IOHIDEventAppendEvent(eventRef.get(), forceEvent.get(), 0);
-    }
-
     return eventRef.leakRef();
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to