Title: [192083] trunk/Source/WebKit2
- Revision
- 192083
- Author
- [email protected]
- Date
- 2015-11-05 15:17:26 -0800 (Thu, 05 Nov 2015)
Log Message
_WKObservablePageState's _webProcessIsResponsive property isn't set to YES when an unresponsive page is reloaded
https://bugs.webkit.org/show_bug.cgi?id=150953
Reviewed by Anders Carlsson.
* UIProcess/ResponsivenessTimer.cpp:
(WebKit::ResponsivenessTimer::processTerminated): Call stop() to
indicate that we are responsive again. This gives the client a chance
to remove the SPOD cursor, among other things.
* UIProcess/ResponsivenessTimer.h:
(WebKit::ResponsivenessTimer::processTerminated): Anders told me to do this!
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetStateAfterProcessExited): Be sure to reset
the responsiveness timer too, or it will continue thinking we are
unresponsive after a crash or a forced load or reload.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (192082 => 192083)
--- trunk/Source/WebKit2/ChangeLog 2015-11-05 23:01:03 UTC (rev 192082)
+++ trunk/Source/WebKit2/ChangeLog 2015-11-05 23:17:26 UTC (rev 192083)
@@ -1,3 +1,23 @@
+2015-11-05 Geoffrey Garen <[email protected]>
+
+ _WKObservablePageState's _webProcessIsResponsive property isn't set to YES when an unresponsive page is reloaded
+ https://bugs.webkit.org/show_bug.cgi?id=150953
+
+ Reviewed by Anders Carlsson.
+
+ * UIProcess/ResponsivenessTimer.cpp:
+ (WebKit::ResponsivenessTimer::processTerminated): Call stop() to
+ indicate that we are responsive again. This gives the client a chance
+ to remove the SPOD cursor, among other things.
+
+ * UIProcess/ResponsivenessTimer.h:
+ (WebKit::ResponsivenessTimer::processTerminated): Anders told me to do this!
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::resetStateAfterProcessExited): Be sure to reset
+ the responsiveness timer too, or it will continue thinking we are
+ unresponsive after a crash or a forced load or reload.
+
2015-11-05 Anders Carlsson <[email protected]>
Move invocation argument encoding out to a separate function
Modified: trunk/Source/WebKit2/UIProcess/ResponsivenessTimer.cpp (192082 => 192083)
--- trunk/Source/WebKit2/UIProcess/ResponsivenessTimer.cpp 2015-11-05 23:01:03 UTC (rev 192082)
+++ trunk/Source/WebKit2/UIProcess/ResponsivenessTimer.cpp 2015-11-05 23:17:26 UTC (rev 192083)
@@ -81,4 +81,10 @@
m_timer.stop();
}
+void ResponsivenessTimer::processTerminated()
+{
+ // Since there is no web process, we must not be waiting for it anymore.
+ stop();
+}
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/UIProcess/ResponsivenessTimer.h (192082 => 192083)
--- trunk/Source/WebKit2/UIProcess/ResponsivenessTimer.h 2015-11-05 23:01:03 UTC (rev 192082)
+++ trunk/Source/WebKit2/UIProcess/ResponsivenessTimer.h 2015-11-05 23:17:26 UTC (rev 192083)
@@ -52,6 +52,8 @@
bool isResponsive() { return m_isResponsive; }
+ void processTerminated();
+
private:
void timerFired();
Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (192082 => 192083)
--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-11-05 23:01:03 UTC (rev 192082)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2015-11-05 23:17:26 UTC (rev 192083)
@@ -5079,6 +5079,8 @@
PageLoadState::Transaction transaction = m_pageLoadState.transaction();
m_pageLoadState.reset(transaction);
+
+ m_process->responsivenessTimer().processTerminated();
}
WebPageCreationParameters WebPageProxy::creationParameters()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
