Title: [192098] trunk
- Revision
- 192098
- Author
- [email protected]
- Date
- 2015-11-06 03:05:55 -0800 (Fri, 06 Nov 2015)
Log Message
Expose HTMLImageElement sizes attribute in IDL
https://bugs.webkit.org/show_bug.cgi?id=150230
Reviewed by Darin Adler.
No new tests, but fixed test expectations for exposed interfaces.
* html/HTMLImageElement.idl: Make sure that `sizes` is exposed as an IDL attribute, to ensure proper feature detection of sizes support.
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (192097 => 192098)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2015-11-06 11:00:23 UTC (rev 192097)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2015-11-06 11:05:55 UTC (rev 192098)
@@ -221,6 +221,7 @@
CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'alt' on a non-HTMLImageElement object.
CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'src' on a non-HTMLImageElement object.
CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'srcset' on a non-HTMLImageElement object.
+CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'sizes' on a non-HTMLImageElement object.
CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'crossOrigin' on a non-HTMLImageElement object.
CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'useMap' on a non-HTMLImageElement object.
CONSOLE MESSAGE: line 1152: Deprecated attempt to access property 'isMap' on a non-HTMLImageElement object.
@@ -2721,7 +2722,9 @@
FAIL HTMLImageElement interface: attribute srcset assert_throws: getting property on prototype object must throw TypeError function "function () {
[native code]
}" did not throw
-FAIL HTMLImageElement interface: attribute sizes assert_true: The prototype object must have a property "sizes" expected true got false
+FAIL HTMLImageElement interface: attribute sizes assert_throws: getting property on prototype object must throw TypeError function "function () {
+ [native code]
+}" did not throw
FAIL HTMLImageElement interface: attribute crossOrigin assert_throws: getting property on prototype object must throw TypeError function "function () {
[native code]
}" did not throw
@@ -2773,7 +2776,7 @@
PASS HTMLImageElement interface: document.createElement("img") must inherit property "alt" with the proper type (0)
PASS HTMLImageElement interface: document.createElement("img") must inherit property "src" with the proper type (1)
PASS HTMLImageElement interface: document.createElement("img") must inherit property "srcset" with the proper type (2)
-FAIL HTMLImageElement interface: document.createElement("img") must inherit property "sizes" with the proper type (3) assert_inherits: property "sizes" not found in prototype chain
+PASS HTMLImageElement interface: document.createElement("img") must inherit property "sizes" with the proper type (3)
PASS HTMLImageElement interface: document.createElement("img") must inherit property "crossOrigin" with the proper type (4)
PASS HTMLImageElement interface: document.createElement("img") must inherit property "useMap" with the proper type (5)
PASS HTMLImageElement interface: document.createElement("img") must inherit property "isMap" with the proper type (6)
@@ -2795,7 +2798,7 @@
PASS HTMLImageElement interface: new Image() must inherit property "alt" with the proper type (0)
PASS HTMLImageElement interface: new Image() must inherit property "src" with the proper type (1)
PASS HTMLImageElement interface: new Image() must inherit property "srcset" with the proper type (2)
-FAIL HTMLImageElement interface: new Image() must inherit property "sizes" with the proper type (3) assert_inherits: property "sizes" not found in prototype chain
+PASS HTMLImageElement interface: new Image() must inherit property "sizes" with the proper type (3)
PASS HTMLImageElement interface: new Image() must inherit property "crossOrigin" with the proper type (4)
PASS HTMLImageElement interface: new Image() must inherit property "useMap" with the proper type (5)
PASS HTMLImageElement interface: new Image() must inherit property "isMap" with the proper type (6)
Modified: trunk/Source/WebCore/ChangeLog (192097 => 192098)
--- trunk/Source/WebCore/ChangeLog 2015-11-06 11:00:23 UTC (rev 192097)
+++ trunk/Source/WebCore/ChangeLog 2015-11-06 11:05:55 UTC (rev 192098)
@@ -1,3 +1,14 @@
+2015-11-06 Yoav Weiss <[email protected]>
+
+ Expose HTMLImageElement sizes attribute in IDL
+ https://bugs.webkit.org/show_bug.cgi?id=150230
+
+ Reviewed by Darin Adler.
+
+ No new tests, but fixed test expectations for exposed interfaces.
+
+ * html/HTMLImageElement.idl: Make sure that `sizes` is exposed as an IDL attribute, to ensure proper feature detection of sizes support.
+
2015-11-05 Carlos Garcia Campos <[email protected]>
[GStreamer] Use RunLoop::Timer instead of GMainLoopSource in video sink
Modified: trunk/Source/WebCore/html/HTMLImageElement.idl (192097 => 192098)
--- trunk/Source/WebCore/html/HTMLImageElement.idl 2015-11-06 11:00:23 UTC (rev 192097)
+++ trunk/Source/WebCore/html/HTMLImageElement.idl 2015-11-06 11:05:55 UTC (rev 192098)
@@ -32,8 +32,8 @@
[Reflect, URL] attribute DOMString longDesc;
[Reflect, URL] attribute DOMString src;
[Reflect] attribute DOMString srcset;
+ [Reflect] attribute DOMString sizes;
#if ENABLE_CURRENTSRC
- [Reflect] attribute DOMString sizes;
readonly attribute DOMString currentSrc;
#endif
[Reflect] attribute DOMString useMap;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
