Title: [192122] trunk/Source/WebCore
- Revision
- 192122
- Author
- [email protected]
- Date
- 2015-11-06 15:58:09 -0800 (Fri, 06 Nov 2015)
Log Message
Remove unused HTMLFormControlsCollection::namedItem()
https://bugs.webkit.org/show_bug.cgi?id=150975
Reviewed by Andreas Kling.
Remove unused HTMLFormControlsCollection::namedItem().
JSHTMLFormControlsCollection::namedItem() calls namedItems() on the
implementation object, not namedItem() because it returns a
RadioNodeList when there are several matches.
* html/HTMLFormControlsCollection.cpp:
(WebCore::firstNamedItem): Deleted.
(WebCore::HTMLFormControlsCollection::namedItem): Deleted.
* html/HTMLFormControlsCollection.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (192121 => 192122)
--- trunk/Source/WebCore/ChangeLog 2015-11-06 23:34:31 UTC (rev 192121)
+++ trunk/Source/WebCore/ChangeLog 2015-11-06 23:58:09 UTC (rev 192122)
@@ -1,3 +1,20 @@
+2015-11-06 Chris Dumez <[email protected]>
+
+ Remove unused HTMLFormControlsCollection::namedItem()
+ https://bugs.webkit.org/show_bug.cgi?id=150975
+
+ Reviewed by Andreas Kling.
+
+ Remove unused HTMLFormControlsCollection::namedItem().
+ JSHTMLFormControlsCollection::namedItem() calls namedItems() on the
+ implementation object, not namedItem() because it returns a
+ RadioNodeList when there are several matches.
+
+ * html/HTMLFormControlsCollection.cpp:
+ (WebCore::firstNamedItem): Deleted.
+ (WebCore::HTMLFormControlsCollection::namedItem): Deleted.
+ * html/HTMLFormControlsCollection.h:
+
2015-11-06 Myles C. Maxfield <[email protected]>
REGRESSION(r182286): Tatechuyoko following ruby is drawn too far to the right
Modified: trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp (192121 => 192122)
--- trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp 2015-11-06 23:34:31 UTC (rev 192121)
+++ trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp 2015-11-06 23:58:09 UTC (rev 192122)
@@ -98,41 +98,6 @@
return nullptr;
}
-static HTMLElement* firstNamedItem(const Vector<FormAssociatedElement*>& elementsArray,
- const Vector<HTMLImageElement*>* imageElementsArray, const QualifiedName& attrName, const String& name)
-{
- ASSERT(attrName == idAttr || attrName == nameAttr);
-
- for (auto& entry : elementsArray) {
- HTMLElement& element = entry->asHTMLElement();
- if (entry->isEnumeratable() && element.fastGetAttribute(attrName) == name)
- return &element;
- }
-
- if (!imageElementsArray)
- return 0;
-
- for (auto& element : *imageElementsArray) {
- if (element->fastGetAttribute(attrName) == name)
- return element;
- }
-
- return nullptr;
-}
-
-HTMLElement* HTMLFormControlsCollection::namedItem(const AtomicString& name) const
-{
- // http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/nameditem.asp
- // This method first searches for an object with a matching id
- // attribute. If a match is not found, the method then searches for an
- // object with a matching name attribute, but only on those elements
- // that are allowed a name attribute.
- auto* imageElements = is<HTMLFieldSetElement>(ownerNode()) ? nullptr : &formImageElements();
- if (HTMLElement* item = firstNamedItem(formControlElements(), imageElements, idAttr, name))
- return item;
- return firstNamedItem(formControlElements(), imageElements, nameAttr, name);
-}
-
void HTMLFormControlsCollection::updateNamedElementCache() const
{
if (hasNamedElementCache())
Modified: trunk/Source/WebCore/html/HTMLFormControlsCollection.h (192121 => 192122)
--- trunk/Source/WebCore/html/HTMLFormControlsCollection.h 2015-11-06 23:34:31 UTC (rev 192121)
+++ trunk/Source/WebCore/html/HTMLFormControlsCollection.h 2015-11-06 23:58:09 UTC (rev 192122)
@@ -47,7 +47,6 @@
private:
explicit HTMLFormControlsCollection(ContainerNode&);
- virtual HTMLElement* namedItem(const AtomicString& name) const override;
virtual void invalidateCache(Document&) override;
virtual void updateNamedElementCache() const override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
