Title: [192775] trunk/Source/WebCore
- Revision
- 192775
- Author
- [email protected]
- Date
- 2015-11-27 00:37:44 -0800 (Fri, 27 Nov 2015)
Log Message
[GTK] Do not use the WebCore garbage collector timer
https://bugs.webkit.org/show_bug.cgi?id=151623
Reviewed by Martin Robinson.
Now that garbage collector timers have been implemented in
_javascript_Core for glib, we don't need to use another Timer in WebCore.
* bindings/js/GCController.cpp:
(WebCore::GCController::garbageCollectSoon):
(WebCore::GCController::garbageCollectNowIfNotDoneRecently):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (192774 => 192775)
--- trunk/Source/WebCore/ChangeLog 2015-11-26 16:43:22 UTC (rev 192774)
+++ trunk/Source/WebCore/ChangeLog 2015-11-27 08:37:44 UTC (rev 192775)
@@ -1,3 +1,17 @@
+2015-11-27 Carlos Garcia Campos <[email protected]>
+
+ [GTK] Do not use the WebCore garbage collector timer
+ https://bugs.webkit.org/show_bug.cgi?id=151623
+
+ Reviewed by Martin Robinson.
+
+ Now that garbage collector timers have been implemented in
+ _javascript_Core for glib, we don't need to use another Timer in WebCore.
+
+ * bindings/js/GCController.cpp:
+ (WebCore::GCController::garbageCollectSoon):
+ (WebCore::GCController::garbageCollectNowIfNotDoneRecently):
+
2015-11-18 Andy Estes <[email protected]>
[Content Filtering] Crash in DocumentLoader::notifyFinished() when allowing a media document to load
Modified: trunk/Source/WebCore/bindings/js/GCController.cpp (192774 => 192775)
--- trunk/Source/WebCore/bindings/js/GCController.cpp 2015-11-26 16:43:22 UTC (rev 192774)
+++ trunk/Source/WebCore/bindings/js/GCController.cpp 2015-11-27 08:37:44 UTC (rev 192775)
@@ -57,12 +57,10 @@
void GCController::garbageCollectSoon()
{
- // We only use reportAbandonedObjectGraph on systems with CoreFoundation
- // since it uses a run-loop-based timer that is currently only available on
- // systems with CoreFoundation. If and when the notion of a run loop is pushed
- // down into WTF so that more platforms can take advantage of it, we will be
- // able to use reportAbandonedObjectGraph on more platforms.
-#if USE(CF)
+ // We only use reportAbandonedObjectGraph for systems for which there's an implementation
+ // of the garbage collector timers in _javascript_Core. We wouldn't need this if _javascript_Core
+ // used a timer implementation from WTF like RunLoop::Timer.
+#if USE(CF) || USE(GLIB)
JSLockHolder lock(JSDOMWindow::commonVM());
JSDOMWindow::commonVM().heap.reportAbandonedObjectGraph();
#else
@@ -92,7 +90,7 @@
void GCController::garbageCollectNowIfNotDoneRecently()
{
-#if USE(CF)
+#if USE(CF) || USE(GLIB)
JSLockHolder lock(JSDOMWindow::commonVM());
if (!JSDOMWindow::commonVM().heap.isBusy())
JSDOMWindow::commonVM().heap.collectAllGarbageIfNotDoneRecently();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
