Title: [192795] trunk/Source/_javascript_Core
- Revision
- 192795
- Author
- [email protected]
- Date
- 2015-11-30 08:56:27 -0800 (Mon, 30 Nov 2015)
Log Message
[ARM64] stress/op_div.js is failing on some divide by 0 cases.
https://bugs.webkit.org/show_bug.cgi?id=151515
Reviewed by Saam Barati.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithDiv):
- Added a check for the divide by zero case.
* tests/stress/op_div.js:
- Un-skipped the test.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (192794 => 192795)
--- trunk/Source/_javascript_Core/ChangeLog 2015-11-30 14:21:06 UTC (rev 192794)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-11-30 16:56:27 UTC (rev 192795)
@@ -1,3 +1,16 @@
+2015-11-26 Mark Lam <[email protected]>
+
+ [ARM64] stress/op_div.js is failing on some divide by 0 cases.
+ https://bugs.webkit.org/show_bug.cgi?id=151515
+
+ Reviewed by Saam Barati.
+
+ * dfg/DFGSpeculativeJIT.cpp:
+ (JSC::DFG::SpeculativeJIT::compileArithDiv):
+ - Added a check for the divide by zero case.
+ * tests/stress/op_div.js:
+ - Un-skipped the test.
+
2015-11-27 Csaba Osztrogonác <[email protected]>
[cmake] Add testb3 to the build system
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (192794 => 192795)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2015-11-30 14:21:06 UTC (rev 192794)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp 2015-11-30 16:56:27 UTC (rev 192795)
@@ -3556,6 +3556,9 @@
numeratorNonZero.link(&m_jit);
}
+ if (shouldCheckOverflow(node->arithMode()))
+ speculationCheck(Overflow, JSValueRegs(), nullptr, m_jit.branchTest32(MacroAssembler::Zero, op2GPR));
+
m_jit.assembler().sdiv<32>(quotient.gpr(), op1GPR, op2GPR);
// Check that there was no remainder. If there had been, then we'd be obligated to
Modified: trunk/Source/_javascript_Core/tests/stress/op_div.js (192794 => 192795)
--- trunk/Source/_javascript_Core/tests/stress/op_div.js 2015-11-30 14:21:06 UTC (rev 192794)
+++ trunk/Source/_javascript_Core/tests/stress/op_div.js 2015-11-30 16:56:27 UTC (rev 192795)
@@ -1,5 +1,4 @@
-//@ skip
-// FIXME: https://bugs.webkit.org/show_bug.cgi?id=151515
+//@ runFTLNoCJIT
// If all goes well, this test module will terminate silently. If not, it will print
// errors. See binary-op-test.js for debugging options if needed.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
