Title: [192852] trunk
- Revision
- 192852
- Author
- [email protected]
- Date
- 2015-11-30 18:29:18 -0800 (Mon, 30 Nov 2015)
Log Message
Modern IDB: Iterating index cursors to a specific key is busted.
https://bugs.webkit.org/show_bug.cgi?id=151684
Reviewed by Darin Adler.
Source/WebCore:
No new tests (At least one failing test now passes).
* Modules/indexeddb/server/MemoryIndexCursor.cpp:
(WebCore::IDBServer::MemoryIndexCursor::iterate):
LayoutTests:
* platform/mac-wk1/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (192851 => 192852)
--- trunk/LayoutTests/ChangeLog 2015-12-01 02:26:57 UTC (rev 192851)
+++ trunk/LayoutTests/ChangeLog 2015-12-01 02:29:18 UTC (rev 192852)
@@ -1,5 +1,14 @@
2015-11-30 Brady Eidson <[email protected]>
+ Modern IDB: Iterating index cursors to a specific key is busted.
+ https://bugs.webkit.org/show_bug.cgi?id=151684
+
+ Reviewed by Darin Adler.
+
+ * platform/mac-wk1/TestExpectations:
+
+2015-11-30 Brady Eidson <[email protected]>
+
Modern IDB: ObjectStore cursors should not be able to iterate out of their range.
https://bugs.webkit.org/show_bug.cgi?id=151683
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (192851 => 192852)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-01 02:26:57 UTC (rev 192851)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2015-12-01 02:29:18 UTC (rev 192852)
@@ -91,6 +91,7 @@
storage/indexeddb/mozilla/event-source.html [ Pass ]
storage/indexeddb/mozilla/global-data.html [ Pass ]
storage/indexeddb/mozilla/index-prev-no-duplicate.html [ Pass ]
+storage/indexeddb/mozilla/indexes.html [ Pass ]
storage/indexeddb/mozilla/key-requirements-delete-null-key.html [ Pass ]
storage/indexeddb/mozilla/key-requirements-inline-and-passed.html [ Pass ]
storage/indexeddb/mozilla/key-requirements-put-no-key.html [ Pass ]
Modified: trunk/Source/WebCore/ChangeLog (192851 => 192852)
--- trunk/Source/WebCore/ChangeLog 2015-12-01 02:26:57 UTC (rev 192851)
+++ trunk/Source/WebCore/ChangeLog 2015-12-01 02:29:18 UTC (rev 192852)
@@ -1,5 +1,17 @@
2015-11-30 Brady Eidson <[email protected]>
+ Modern IDB: Iterating index cursors to a specific key is busted.
+ https://bugs.webkit.org/show_bug.cgi?id=151684
+
+ Reviewed by Darin Adler.
+
+ No new tests (At least one failing test now passes).
+
+ * Modules/indexeddb/server/MemoryIndexCursor.cpp:
+ (WebCore::IDBServer::MemoryIndexCursor::iterate):
+
+2015-11-30 Brady Eidson <[email protected]>
+
Modern IDB: ObjectStore cursors should not be able to iterate out of their range.
https://bugs.webkit.org/show_bug.cgi?id=151683
Modified: trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp (192851 => 192852)
--- trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp 2015-12-01 02:26:57 UTC (rev 192851)
+++ trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndexCursor.cpp 2015-12-01 02:29:18 UTC (rev 192852)
@@ -88,9 +88,9 @@
}
if (m_info.isDirectionForward())
- m_currentIterator = valueStore->find(m_currentKey);
+ m_currentIterator = valueStore->find(key);
else
- m_currentIterator = valueStore->reverseFind(m_currentKey, m_info.duplicity());
+ m_currentIterator = valueStore->reverseFind(key, m_info.duplicity());
if (!m_currentIterator.isValid()) {
m_currentKey = { };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
