Title: [192933] trunk/Tools
- Revision
- 192933
- Author
- [email protected]
- Date
- 2015-12-01 17:25:12 -0800 (Tue, 01 Dec 2015)
Log Message
EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
<http://webkit.org/b/151726>
Reviewed by Simon Fraser.
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (192932 => 192933)
--- trunk/Tools/ChangeLog 2015-12-02 01:24:17 UTC (rev 192932)
+++ trunk/Tools/ChangeLog 2015-12-02 01:25:12 UTC (rev 192933)
@@ -1,3 +1,14 @@
+2015-12-01 David Kilzer <[email protected]>
+
+ EventSenderProxy::swipeGestureWithWheelAndMomentumPhases() leaks an EventSenderSyntheticEvent
+ <http://webkit.org/b/151726>
+
+ Reviewed by Simon Fraser.
+
+ * WebKitTestRunner/mac/EventSenderProxy.mm:
+ (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
+ Deploy RetainPtr<EventSenderSyntheticEvent> to fix leak.
+
2015-12-01 Myles C. Maxfield <[email protected]>
Give String and AtomicString an existingHash() function
Modified: trunk/Tools/WebKitTestRunner/mac/EventSenderProxy.mm (192932 => 192933)
--- trunk/Tools/WebKitTestRunner/mac/EventSenderProxy.mm 2015-12-02 01:24:17 UTC (rev 192932)
+++ trunk/Tools/WebKitTestRunner/mac/EventSenderProxy.mm 2015-12-02 01:25:12 UTC (rev 192933)
@@ -930,7 +930,7 @@
void EventSenderProxy::swipeGestureWithWheelAndMomentumPhases(int x, int y, int phase, int momentum)
{
- EventSenderSyntheticEvent *event = [[EventSenderSyntheticEvent alloc] init];
+ RetainPtr<EventSenderSyntheticEvent> event = adoptNS([[EventSenderSyntheticEvent alloc] init]);
// "mayBegin" a swipe is actually a scroll wheel event.
event->_eventSender_type = (phase == 128) ? NSScrollWheel : NSEventTypeGesture;
@@ -950,7 +950,7 @@
NSLog(@"Synthetic swipe gestures are not implemented for 32-bit WebKitTestRunner.");
#endif
- [NSApp sendEvent:event];
+ [NSApp sendEvent:event.get()];
}
} // namespace WTR
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
